Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ffmpeg extras #5277

Merged
merged 22 commits into from
May 28, 2022
Merged

ffmpeg extras #5277

merged 22 commits into from
May 28, 2022

Conversation

th0ma7
Copy link
Contributor

@th0ma7 th0ma7 commented May 16, 2022

Description

ffmpeg extras: Add extra version tag to easily identify running version along with encoders/decoders to ffmpeg

Includes a generic fix for packages that link to libatomic and must include this library from the toolchain in the package.

Fixes #5254

Checklist

  • Build rule all-supported completed successfully
  • New installation of package completed successfully
  • Package upgrade completed successfully (Manually install the package again)
  • Package functionality was tested
  • Any needed documentation is updated/created

Type of change

  • Bug fix
  • New Package
  • Package update
  • Includes small framework changes
  • This change requires a documentation update (e.g. Wiki)

@th0ma7 th0ma7 self-assigned this May 16, 2022
@th0ma7
Copy link
Contributor Author

th0ma7 commented May 19, 2022

Issue found while trying to integrate codec2 https://github.com/drowe67/codec2/issues/324

th0ma7 and others added 3 commits May 27, 2022 13:12
- create lib folder on demand
- ensure full name of libatomic
@hgy59
Copy link
Contributor

hgy59 commented May 27, 2022

@th0ma7 just identified redis package build for qoriq needs libatomic too.
But staging/lib folder does not exist here at time of libatomic installation.

@hgy59
Copy link
Contributor

hgy59 commented May 27, 2022

@th0ma7 thanks for triggering the failed (tvh timeouted) builds again.

@th0ma7
Copy link
Contributor Author

th0ma7 commented May 27, 2022

just identified redis package build for qoriq needs libatomic too. But staging/lib folder does not exist here at time of libatomic installation.

@hgy59 Good catch! We'll eventually get it right ;) I've restarted failed jobs to confirm all is good then I'll merge.

@hgy59
Copy link
Contributor

hgy59 commented May 27, 2022

we now have a good work-around for it!

Shame on synology, to have shared libraries in toolchains, that are not available on the devices.

@hgy59 hgy59 self-requested a review May 27, 2022 18:51
@hgy59 hgy59 changed the title [WIP] ffmpeg extras ffmpeg extras May 28, 2022
@hgy59 hgy59 merged commit dda9689 into SynoCommunity:master May 28, 2022
@th0ma7 th0ma7 added the status/published Published and activated (may take up to 48h until visible in DSM package manager) label May 28, 2022
@th0ma7 th0ma7 deleted the ffmpeg-extras branch May 28, 2022 20:19
AlexPresso pushed a commit to AlexPresso/spksrc that referenced this pull request Jan 30, 2025
* ffmpeg: Add extra-version flag to match SPK_VER
* ffmpeg: Enable WebP encoder/decoder
* docker-tvheadend: Update digests against master
* tvheadend: Fix version so digests is constant
* ffmpeg: Add candidates for enablement
* ffmpeg: Convert from enable-fontconfig to enable-libfontconfig
* chromaprint: Update from version 1.5.0 to 1.5.1
* chromaprint: Update changelog
* ffmpeg: Enable caca (color ASCII art) and rabbitmq support
* ffmpeg: Enable frei0r pligin API support
* ffmpeg: Misc fixes related to rabbitmq & frei0r for proper build
* frei0r: Fix PLIST and remove depends
* ffmpeg: Adjust frei0r PLIST with cairo removal
* frei0r: Re-include freetype + TODO comments related to cairo
* chromaprint: Build fixes
* ffmpeg: Enable zimg image processing support
* ffmpeg: Enable libdc1394 camera support
* docker-tvheadend: Use latest release instead of git hash
* strip.mk: Auto-detect and include libatomic.so as needed
* strip.mk: Minor adjustments based on @hgy59 feedbacks
* strip.mk: Include @hgy59 proposed changes to manage libatomic.so

Co-Author: hgy59 <hpgy59@gmail.com>

* fix include_libatomic

- create lib folder on demand
- ensure full name of libatomic

Co-authored-by: hgy59 <hpgy59@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
framework status/published Published and activated (may take up to 48h until visible in DSM package manager)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ffmpeg 4.4.2-43 cannot find libatomic.so.1 tvheadend cannot find libatomic
2 participants