pyhon3* wheel fixes + TVH Fall 2021 update & Fix 403 Forbidden #4921
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1. Use -C flag at startup to manage the initial creation of the admin user account using built-in app functionality instead of playing with wizard. This allow removing wizard entirely along with POST_STRIP_TARGET. 2. Enable logs using the -l flag 3. Update to version from October 16th 2021 (git 1ee9c5b) 4. Fix SPK_DEPENDS to add ffmpeg on top of python38
1. Use -C flag at startup to manage the initial creation of the admin user account using built-in app functionality instead of playing with wizard. This allow removing wizard entirely along with POST_STRIP_TARGET. 2. Enable logs using the -l flag 3. Update to version from October 16th 2021 (git 1ee9c5b) 4. Fix SPK_DEPENDS to add ffmpeg on top of python38
This was
linked to
issues
Oct 17, 2021
Safihre
reviewed
Oct 19, 2021
mk/spksrc.wheel.mk
Outdated
| fi | ||
|
|
||
| build_wheel_target: $(PRE_WHEEL_TARGET) | ||
| @if [ ! -z "$(WHEELS)" ] ; then \ | ||
| $(foreach e,$(shell cat $(WORK_DIR)/python-cc.mk),$(eval $(e))) \ | ||
| if [ ! -z "$(CROSS_COMPILE_WHEELS)" ] ; then \ | ||
| if [ -f "$(WORK_DIR)/wheelhouse/cross-requirements.txt" ]; then \ |
There was a problem hiding this comment.
So what happens here? How does the rename from requirements to cross-requirements fixes things?
There was a problem hiding this comment.
its not only a rename but rather telling to cross-compile the ones in cross and "python" compile the other ones by default (e.g. pure). Again for reference #4925 (comment)
hgy59
reviewed
Oct 19, 2021
This is to address finding from @Safihre: SynoCommunity#4921 (comment)
|
@Safihre related to your previous comment:
How do you figure out what's pure vs cross (other than looking for build failures)? Using that, would you have a moment to help out and revisit this PR in order to move wheels from cross to pure in affected packages when you see fit so only a minimal set of cross wheels remain? |
I looked at the pypi.org pages for each package, if they are binary then they usually have many |
|
I installed the @hgy59 or @publicarray Looks good to me, maybe you have any more comments?
|
|
Thnx @Safihre this is much appreciated.
|
|
@Safihre I've nwo pushed all the changes (with exception of |
Safihre
reviewed
Oct 22, 2021
I rebased my SABnzbd PR on this one and it works as expected. |
|
Great, thnx for this initial feedback. |
Yes, it's used by a lot of packages (13 from what I see). Even more (18) use it's big brother: |
|
Python 3 & 38 are very useful and important packages why not pop in |
|
@BKSteve good point although conceptually there is more to that:
All in all there is a point where we have to get things out and wait for the right time for subsequent changes. As such I tend to agree with @Safihre , lets get this one out and fix multiple issues right away, and leave the remaining for later. |
3 tasks
|
Tested and works as expected :) |
Yep, so much time spent building Python with all it's own cross and native items, it would be great if this was a |
3 tasks
3 tasks
This was referenced Nov 3, 2021
AlexPresso
pushed a commit
to AlexPresso/spksrc
that referenced
this pull request
Jan 30, 2025
…ommunity#4921) * libhdhomerun: Update to version 2021-06-24 * tvheadend: Update version and many fixes 1. Use -C flag at startup to manage the initial creation of the admin user account using built-in app functionality instead of playing with wizard. This allow removing wizard entirely along with POST_STRIP_TARGET. 2. Enable logs using the -l flag 3. Update to version from October 16th 2021 (git 1ee9c5b) 4. Fix SPK_DEPENDS to add ffmpeg on top of python38 * tvheadend: Remove wizard entries and add python38 build-dep * python38: Add platformdirs to default wheels * python38: Add cross/platformdirs * python38: Bump package version * python3*: Use pip version 21.3 for cross and native * native/python3: Update to pip 21.3 and enfore crossenv==1.0 * python38: Re-enable optimizations and lto * tvheadend: Remove python build depend as pure python * common.mk: Move --requirements option to wheels.mk * wheel.mk: Manage --requirement option and allow cross & pure * python3*: Manage pure and cross requirements[-cross].txt * python3*: Downgrade virtualenv back to previous version 20.4.6 * borgbackup: Fix python wheels * spk.mk: Add wheelhouse to spkclean * pyhon-wheel.mk: Use global variables and check for pure-python * salt-minion: Fix python wheels * python38: Update filelock to version 3.3.1 * python3: Downgrade filelock to version 3.0.12 * duplicity: Fix python wheels * rdiff-backup: Fix python wheels * homeassistant: Fix python wheels * sabnzbd: Fix python wheels * flexget: Fix python wheels and migrate to python38 * wheel.mk: Force adding newline to requirement file This is to address finding from @Safihre: SynoCommunity#4921 (comment) * multi: Migrate wheels from cross to pure when applicable * wheel.mk: Process pure-python wheels before cross * python3: Migrate pure-python wheels from cross to pure * python38: Re-order cross/* and add greenlet as used by many * tvheadend: Update to latest comit from Oct. 20th 2021 * Move urllib3 from cross to pure python wheel
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation: Update
tvheadendto latest available version and:-Cflag at startup to manage the initial creation of the admin user account using built-in app functionality instead of playing with wizard. This allow removing wizard entirely along withPOST_STRIP_TARGET.-lflag1ee9c5b)SPK_DEPENDSto addffmpegon top ofpython38tvheadendspecific changes from4797to its own PRIMPORTANT: While investigating I also found issues with latest python38 package (ref. #4925). Currently this PR also contains important fixes for python3* to work properly.
Linked issues: #4758 and #3707 for
tvheadendand created #4925 while investigatingChecklist
all-supportedcompleted successfully