Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chromaprint build fix #4103

Merged
merged 5 commits into from
Aug 5, 2020
Merged

Conversation

th0ma7
Copy link
Contributor

@th0ma7 th0ma7 commented Aug 4, 2020

Motivation: Since migration to cmake helpers chromaprint does not build anymore. Intent is to solve that issue while keeping linkage to ffmpeg.
Linked issues: acoustid/chromaprint#79

Checklist

  • Build rule all-supported completed successfully
  • Package upgrade completed successfully
  • New installation of package completed successfully

Sub-builds checks:

  • cross/libwebsockets
  • cross/intel-media-driver
  • cross/intel-media-sdk
  • cross/libmysqlclient
  • cross/libaom
  • cross/gmmlib
  • cross/chromaprint
  • cross/umurmur
  • cross/soxr
  • cross/svt-av1
  • cross/svt-hevc
  • cross/uchardet

@th0ma7 th0ma7 self-assigned this Aug 4, 2020
@th0ma7 th0ma7 mentioned this pull request Aug 4, 2020
3 tasks
@th0ma7 th0ma7 changed the title [WIP] chromaprint build fix chromaprint build fix Aug 5, 2020
@th0ma7 th0ma7 requested a review from ymartin59 August 5, 2020 10:56
@ymartin59
Copy link
Contributor

@th0ma7 armv7 builds have fail... something to check too

@th0ma7
Copy link
Contributor Author

th0ma7 commented Aug 5, 2020

@th0ma7 armv7 builds have fail... something to check too

Yeah, armv7 and other failures have all related to download failures as I was teting my code against it and all is OK:

2020-08-05T12:58:11.9115015Z wget https://gmplib.org/download/gmp/gmp-6.1.2.tar.lz
2020-08-05T13:00:22.2950088Z failed: Connection timed out.
2020-08-05T13:02:33.3670761Z failed: Connection timed out.
2020-08-05T13:04:46.4870198Z failed: Connection timed out.
2020-08-05T13:06:59.6070674Z failed: Connection timed out.
2020-08-05T13:09:14.7751315Z failed: Connection timed out.
2020-08-05T13:11:29.9430660Z failed: Connection timed out.
2020-08-05T13:13:45.1187932Z failed: Connection timed out.
2020-08-05T13:16:02.3269972Z failed: Connection timed out.
2020-08-05T13:18:19.8135517Z failed: Connection timed out.
2020-08-05T13:20:38.8071394Z failed: Connection timed out.
2020-08-05T13:22:58.0710807Z failed: Connection timed out.
2020-08-05T13:25:17.3350395Z failed: Connection timed out.
2020-08-05T13:27:36.5989853Z failed: Connection timed out.
2020-08-05T13:29:55.8631570Z failed: Connection timed out.
2020-08-05T13:32:15.1270066Z failed: Connection timed out.
2020-08-05T13:34:34.3912289Z failed: Connection timed out.
2020-08-05T13:36:53.6553081Z failed: Connection timed out.
2020-08-05T13:39:12.9191086Z failed: Connection timed out.
2020-08-05T13:41:32.1830058Z failed: Connection timed out.
2020-08-05T13:43:51.4473041Z failed: Connection timed out.
2020-08-05T13:43:51.4478036Z make[4]: *** [../../mk/spksrc.download.mk:57: download_target] Error 4
2020-08-05T13:43:51.4478929Z make[4]: Leaving directory '/github/workspace/cross/gmp'
2020-08-05T13:43:51.4486813Z make[3]: *** [../../mk/spksrc.depend.mk:44: depend_target] Error 2

@th0ma7 th0ma7 merged commit 6050b8a into SynoCommunity:master Aug 5, 2020
@th0ma7 th0ma7 deleted the chromaprint-build-fix branch August 5, 2020 23:38
@ymartin59
Copy link
Contributor

@th0ma7 You have to test commands in package at least on one system (for instance xpenology virtual machine)

$ fpcalc --version
fpcalc: error while loading shared libraries: libchromaprint.so.1: cannot open shared object file: No such file or directory

@th0ma7
Copy link
Contributor Author

th0ma7 commented Aug 20, 2020

I think I've found the issue.
I had tested it just before switching to shared lib without updating the PLIST ...

AlexPresso pushed a commit to AlexPresso/spksrc that referenced this pull request Jan 30, 2025
* chromaprint: Build fix with direct and against linked ffmpeg

* Version bump for next ffmpeg 4.2.4 release

* chromaprint: Mark powerpc arches as unsupported
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants