-
-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update Chromaprint to 1.3.2 and ffmpeg to 3.3.3 and dependencies #2865
Update Chromaprint to 1.3.2 and ffmpeg to 3.3.3 and dependencies #2865
Conversation
@ymartin59 : Great. Thanks for this! First successes with compiling TVH against your |
I still have troubles with chromaprint dynamic linkage to ffmpeg libraries, in progress... |
@ymartin59 : I have just successfully re-compiled TVH with all 6.1 toolchains against your P.S.: There is some interesting information on dynamically linking ffmpeg in #1900. FWIW... |
@ymartin59 : I have successfully re-compiled TVH with all 5.2 toolchains against your |
@ymartin59 Could you get in touch with me about this, maybe via direct message on Twitter - https://twitter.com/dan_gravell or email is fine: https://www.blisshq.com/contact.html ? I failed to use BountySource to attach bounty to #2812 and want to discuss with you... |
Depends on ffmpeg package instead of Chromaprint specific cross/ffmpeg-2.2.1 Dependencies updates: - expat 2.2.2 - fdk-acc 0.1.5 - ffmpeg 3.3.3 - fontconfig 2.12.4 - freetype 2.8 - gmp 6.1.2 - libbluray 1.0.1 - opus 1.2.1 - x264 20170730-2245-stable - x265 2.1 for PPC and 2.5 for others
3fbc8d6
to
a42f956
Compare
@cytec @KaraokeStu May you please review this ffmpeg/chromaprint upgrade so that I may publish packages ? |
@ymartin59 : Just a quick follow-up: Runtime test of TVH compiled against your ffmpeg-3.3.3 on evansport with 6.1 toolchains has been successful too. Will PR the transition to the general ffmpeg package for TVH, once your PR here has been merged. Thanks again! |
@ymartin59 When you say "publish packages" to where do you mean? I thought the repo only provided DSM 5.x packages right now? |
@gravelld That is right. I expect to publish new ffmpeg/chromaprint versions into SynoCommunity public repository for DSM 5.2 platforms. |
Oh, apologise, realise now that this is mostly about Chromaprint upgrade for all DSM versions... |
@cytec @KaraokeStu May you please review this ffmpeg/chromaprint upgrade so that I may publish packages ? |
Depends on ffmpeg package instead of Chromaprint specific cross/ffmpeg-2.2.1
Dependencies updates:
Motivation: Security update https://nvd.nist.gov/vuln/detail/CVE-2017-9993
Linked issues: #2812 #2775 #2834
Checklist
all-supported
completed successfully - for bothspk/chromaprint
andspk/ffmpeg
spk/chromaprint
andspk/ffmpeg
spk/chromaprint
andspk/ffmpeg