Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace wherever possible boost types with std ones #986

Merged
merged 13 commits into from
Jul 26, 2021
Merged

Replace wherever possible boost types with std ones #986

merged 13 commits into from
Jul 26, 2021

Conversation

evgueni-ovtchinnikov
Copy link
Contributor

Trying to fix #241.

KrisThielemans
KrisThielemans requested changes Jul 26, 2021
View reviewed changes
Copy link
Member

@KrisThielemans KrisThielemans left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this looks great to me. Possibly the CMakeLists.txt could be adapted to drop some boost dependencies explicitly?

src/common/include/sirf/common/iequals.h Show resolved Hide resolved
src/common/iequals.cpp Show resolved Hide resolved
@evgueni-ovtchinnikov
Copy link
Contributor Author

@KrisThielemans re drop boost in CMakeLists.txt: so far as I can see, boost::algorithm is not referred there, some other boost libraries are still in use unfortunately

@KrisThielemans
Copy link
Member

some other boost libraries are still in use unfortunately

ok.

KrisThielemans
KrisThielemans requested changes Jul 26, 2021
View reviewed changes
Copy link
Member

@KrisThielemans KrisThielemans left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sorry. doxygen needs to be before the function (not just the file)

src/common/include/sirf/common/iequals.h Outdated Show resolved Hide resolved
src/common/include/sirf/common/iequals.h Show resolved Hide resolved
@evgueni-ovtchinnikov evgueni-ovtchinnikov merged commit cb4d251 into master Jul 26, 2021
@evgueni-ovtchinnikov evgueni-ovtchinnikov deleted the de-boost branch March 30, 2022 15:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@KrisThielemans KrisThielemans KrisThielemans approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

remove boost dependency as much as possible
2 participants
@evgueni-ovtchinnikov @KrisThielemans