Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PYTHON_DEST fixes #623

Merged
merged 3 commits into from
Nov 6, 2021
Merged

PYTHON_DEST fixes #623

merged 3 commits into from
Nov 6, 2021

Conversation

KrisThielemans
Copy link
Member

fixes problem when PYTHON_DEST_DIR (or CMAKE_INSTALL_PREFIX?) isn't set

fixes SyneRBI/SIRF#1020

@KrisThielemans
fix use of PYTHON_DEST_DIR
fe8126b 
We passed PYTHON_DEST_DIR to SIRF and TomoPhantom. However, when it is
set, this would write in /.

Fix is to pass PYTHON_DEST (which defaults to CMAKE_INSTALL_PREFIX/python)
@KrisThielemans
remove copy-paste lines to avoid conflicts
2267ea1 
lines related to PYTHON_DEST and PYTHON_STRATEGY were copied here
but potentially overwrote what was set in SuperBuild.cmake
@KrisThielemans
Clarification of PYTHON_DEST_DIR etc
2984757
@KrisThielemans KrisThielemans added this to the v3.2 milestone Nov 4, 2021
@KrisThielemans
Copy link
Member Author

@paskino @evgueni-ovtchinnikov can we merge this? I think it looks great 😄

@evgueni-ovtchinnikov
Copy link
Contributor

same trouble persist on my VM, I am afraid:
build_log.txt
make_log.txt
cmake_install.cmake.txt

@KrisThielemans
Copy link
Member Author

I don't understand, and will have a look later. I notice

-- Found PythonInterp: /usr/bin/python (found version "2.7.18") 
-- Found PYTHON_EXECUTABLE=/usr/bin/python
-- Python version 2.7.18
-- Found PythonLibs: /usr/lib/x86_64-linux-gnu/libpython3.8.so (found version "3.8.10") 
-- Found PYTHON_INCLUDE_DIRS=/usr/include/python3.8
-- Found PYTHON_LIBRARIES=/usr/lib/x86_64-linux-gnu/libpython3.8.so

that's bound to give problems.

paskino
paskino approved these changes Nov 5, 2021
View reviewed changes
Copy link
Contributor

@paskino paskino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine to me. Significantly simplifies the code and it's all green!

@evgueni-ovtchinnikov
Copy link
Contributor

changed /usr/bin/python to /usr/bin/python3 manually in ccmake - now SIRF builds!

evgueni-ovtchinnikov
evgueni-ovtchinnikov approved these changes Nov 5, 2021
View reviewed changes
Copy link
Contributor

@evgueni-ovtchinnikov evgueni-ovtchinnikov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

a comment on Python needed in the installation instructions

@KrisThielemans KrisThielemans merged commit 4483562 into SyneRBI:master Nov 6, 2021
@KrisThielemans KrisThielemans deleted the PYTHON_DEST_fixes branch November 6, 2021 09:55
@KrisThielemans KrisThielemans mentioned this pull request Nov 6, 2021
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@evgueni-ovtchinnikov evgueni-ovtchinnikov evgueni-ovtchinnikov approved these changes

@paskino paskino paskino approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v3.2
Development

Successfully merging this pull request may close these issues.

SIRF build error on Ubuntu 20.04
3 participants
@KrisThielemans @evgueni-ovtchinnikov @paskino