docker: entrypoint fails if group exists

[KrisThielemans]

Found by @mastergari

./sirf-compose tries to find the group of the current user, and create a group in the docker image accordingly. However, when that group already exists, subsequent adduser fails:

“Creating sirfuser:501:20
addgroup: The GID `20' is already in use.
adduser: The group `sirfuser' does not exist.
addgroup: The user `sirfuser' does not exist.
Updating file ownership for /home/sirfuser
chown: invalid user: ‘sirfuser:sirfuser’
Switching to sirfuser and executing /usr/local/bin/service.sh
error: failed switching to "sirfuser": unable to find user sirfuser: no matching entries in passwd file”

[KrisThielemans]

The problem is in the following lines

SIRF-SuperBuild/docker/entrypoint.sh

Lines 28 to 34 in 3c01b37

	addgroup --quiet --system --gid "$GROUP_ID" "$mainUser"
	# useradd --shell /bin/bash -u $USER_ID -o -c "" -M -d $HOME \
	# -g $mainUser -G sudo $mainUser \
	# -p $(echo somepassword | openssl passwd -1 -stdin)
	adduser --quiet --system --shell /bin/bash \
	--no-create-home --home /home/"$mainUser" \
	--ingroup "$mainUser" --uid "$USER_ID" "$mainUser"

The adduser command should use the --gid option as opposed to --ingroup, as the groupname would have failed.

[KrisThielemans]

A possibly work-around for an existing image could be to edit sirf-compose and say

cd "$(dirname $0)"
export GROUP_ID=10000 # some non-existent group  number
export USER_ID=$(id -u)
docker-compose -f docker-compose.yml -f docker-compose.nix.yml "$@"

or equivalently edit

SIRF-SuperBuild/docker/docker-compose.yml

Line 9 in 3c01b37

GROUP_ID: ${GROUP_ID:-1000}

to

  GROUP_ID: 10000

[KrisThielemans]

Better would be to pull the PR:

cd /wherever/SIRF-SuperBuild/docker
git remote add kris-fork git@github.com:KrisThielemans/SIRF-SuperBuild.git
git fetch kris-fork
git checkout docker_group_fix
./sirf-compose-server down 
./sirf-compose-server build sirf
docker image prune # get rid of previous image
./sirf-compose-server up -d sirf

[KrisThielemans]

@mastergari let us know if you try either of those.

[KrisThielemans]

This works for me, but of course I never had the problem.

[mastergari]

@KrisThielemans I am able to access localhost:9999 after editing sirf-comopose with your above commands. I was unable to pull the PR which failed at "git fetch kris-fork" due to insufficient access rights:

  Warning: Permanently added the RSA host key for IP address '140.82.112.4' to the list of known hosts.
  git@github.com: Permission denied (publickey).
  fatal: Could not read from remote repository.
  
  Please make sure you have the correct access rights
  and the repository exists.

I had no problems setting up docker on my linux machine. Thank you for the assistance!

[KrisThielemans]

oops.

git remote add kris-fork https://github.com/KrisThielemans/SIRF-SuperBuild.git

Anyway. We'll probably merge this tomorrow. Thanks for letting us know!