Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

astra-toolbox fails to update on a fresh VM #605

Closed
KrisThielemans opened this issue Jun 28, 2021 · 2 comments · Fixed by #608
Closed

astra-toolbox fails to update on a fresh VM #605

KrisThielemans opened this issue Jun 28, 2021 · 2 comments · Fixed by #608
Assignees
Milestone

Comments

@KrisThielemans
Copy link
Member

Doing make astra-toolbox fails with

*** Please tell me who you are.
Run
  git config --global user.email "you@example.com"
  git config --global user.name "Your Name"
to set your account's default identity.
Omit --global to set the identity only in this repository.
fatal: empty ident name (for <sirfuser@vagrant.vm>) not allowed
Cannot save the current index state
CMake Error at /home/sirfuser/devel/buildVM/builds/astra-toolbox/tmp/astra-toolbox-gitupdate.cmake:80 (message):
  Failed to stash changes
CMakeFiles/astra-toolbox.dir/build.make:115: recipe for target 'builds/astra-toolbox/stamp/astra-toolbox-update' failed
make[2]: *** [builds/astra-toolbox/stamp/astra-toolbox-update] Error 1
CMakeFiles/Makefile2:844: recipe for target 'CMakeFiles/astra-toolbox.dir/all' failed
make[1]: *** [CMakeFiles/astra-toolbox.dir/all] Error 2

reason is

sirfuser@vagrant:~/devel/buildVM/sources/astra-toolbox$ git status
HEAD detached at origin/master
Untracked files:
  (use "git add <file>..." to include in what will be committed)

	python/python_build
	python/python_install
	python_build
	python_install
@KrisThielemans
Copy link
Member Author

need to be added to .gitignore I guess. Possibly via patch

@paskino
Copy link
Contributor

paskino commented Jun 28, 2021

Or possibly remove those files after the INSTALL step, because the problem probably arises from doing a git pull before the PATCH_COMMAND.

Currently, however I remove the files at the beginning:

PATCH_COMMAND ${CMAKE_COMMAND} -E chdir ${${proj}_SOURCE_DIR} ${CMAKE_COMMAND} -E remove -f python_build && ${CMAKE_COMMAND} -E remove -f python_install

paskino added a commit that referenced this issue Jul 1, 2021
Decouples the build of the astra library from its python wrapper by adding a new project astra-python-wrapper, thereby removing code from External_astra-toolbox.cmake that was relative to the build of the python wrapper.

Also it saves the python_build and python_install files in the BINARY_DIR rather than in the SOURCE_DIR which was the source of problems for git.

closes #605
@KrisThielemans KrisThielemans added this to the v3.1.x milestone Jul 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants