Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Setting CMAKE_CXX_STANDARD (for STIR, ITK etc) #180

Open
KrisThielemans opened this issue Jan 10, 2019 · 1 comment
Open

Setting CMAKE_CXX_STANDARD (for STIR, ITK etc) #180

KrisThielemans opened this issue Jan 10, 2019 · 1 comment
Milestone

Comments

@KrisThielemans
Copy link
Member

Every package has different ways to set the C++ standard, which is problematic as libraries and .h files aren't necessarily compatible, leading to crashes or linking problems, see e.g. #161. It seems therefore safer that if we compile stuf ourselves, to try and convince the package to use a particular C++ version.

At present, we set CMAKE_CXX_STANDARD to 11 for STIR. This hasn't create problems yet, but I do get warnings with ITK (that ITK was compiled with a more recent C++ standard).

There's a few possibilities:

  1. relying on the packages and their default choices for the particular compiler we're using (wouldn't currently for STIR)
  2. attempting to enforce a C++ standard

Seems to me that we need to find out what C++ version is used for Gadgetron and build boost with the same version (as in #161), but also build ITK, STIR and whatever with the same version. I hope that for all CMake packages, this just means specifying CMAKE_CXX_STANDARD (I haven't check the ITK code).

@KrisThielemans KrisThielemans changed the title Setting CMAKE_CXX_STANDARD (for STIR) Setting CMAKE_CXX_STANDARD (for STIR, ITK etc) Jan 10, 2019
@KrisThielemans
Copy link
Member Author

This is important but I don't think urgent, and wouldn't break backwards compatibility. I';; therefore assign to v2.1, but please comment if you disagree.

@KrisThielemans KrisThielemans added this to the v2.1 milestone Feb 15, 2019
@KrisThielemans KrisThielemans modified the milestones: v2.1, v2.2 Oct 6, 2019
@KrisThielemans KrisThielemans modified the milestones: v3.0, v3.1 Mar 11, 2021
paskino pushed a commit to paskino/SIRF-SuperBuild that referenced this issue Oct 25, 2021
give Python executable a variable in UPDATE.sh
@KrisThielemans KrisThielemans modified the milestones: v3.4, v4.0 Jan 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant