Skip to content

feat(runtime): implement bpf-execution without program cache #645

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 24 commits into from
Apr 4, 2025

Conversation

yewman
Copy link
Contributor

@yewman yewman commented Mar 26, 2025

This PR implements an intermediary approach to bpf program execution. Specifically program elf's are loaded and validated for every invocation. This will be replaced by the use of a program cache once available

@github-project-automation github-project-automation bot moved this to 🏗 In progress in Sig Mar 26, 2025
@yewman yewman marked this pull request as draft March 26, 2025 20:25
@yewman yewman changed the base branch from main to harnew/serialisation March 26, 2025 20:26
@yewman yewman changed the title feat(bpf-execution): implement bpf-execution without program cache feat(runtime): implement bpf-execution without program cache Mar 26, 2025
@yewman yewman force-pushed the harnew/serialisation branch from 633d681 to ddaed0e Compare March 26, 2025 23:25
@yewman yewman force-pushed the harnew/bpf-execution-v2 branch from de7efb9 to 856b1a9 Compare March 31, 2025 21:11
Base automatically changed from harnew/serialisation to main March 31, 2025 21:23
@yewman yewman marked this pull request as ready for review March 31, 2025 22:33
Copy link

codecov bot commented Mar 31, 2025

Codecov Report

Attention: Patch coverage is 88.60104% with 22 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
src/runtime/program/bpf/execute.zig 84.37% 15 Missing ⚠️
src/runtime/program/testing.zig 62.50% 3 Missing ⚠️
src/runtime/testing.zig 33.33% 2 Missing ⚠️
src/vm/syscalls.zig 0.00% 2 Missing ⚠️
Files with missing lines Coverage Δ
src/runtime/feature_set.zig 100.00% <ø> (ø)
...c/runtime/program/address_lookup_table/execute.zig 89.04% <100.00%> (+0.21%) ⬆️
src/runtime/program/bpf/serialize.zig 89.64% <ø> (ø)
src/runtime/program/bpf/tests.zig 100.00% <100.00%> (ø)
src/runtime/program/bpf_loader/execute.zig 87.15% <100.00%> (+0.78%) ⬆️
src/runtime/program/system/execute.zig 86.01% <100.00%> (ø)
src/runtime/program/vote/execute.zig 96.32% <100.00%> (ø)
src/runtime/transaction_context.zig 100.00% <100.00%> (+4.65%) ⬆️
src/vm/elf.zig 91.76% <100.00%> (+1.03%) ⬆️
src/vm/executable.zig 98.50% <100.00%> (+0.31%) ⬆️
... and 5 more

... and 3 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@yewman yewman force-pushed the harnew/bpf-execution-v2 branch from a3cb092 to f56db13 Compare April 1, 2025 15:21
@yewman yewman requested review from Rexicon226 and kprotty April 2, 2025 14:17
Copy link
Contributor

@Rexicon226 Rexicon226 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome milestone!

@github-project-automation github-project-automation bot moved this from 🏗 In progress to 👀 In review in Sig Apr 2, 2025
@yewman yewman requested review from kprotty and Rexicon226 April 2, 2025 17:23
@yewman yewman force-pushed the harnew/bpf-execution-v2 branch from 19208e5 to 468b74b Compare April 4, 2025 03:12
@yewman yewman requested a review from Rexicon226 April 4, 2025 17:13
@yewman yewman added this pull request to the merge queue Apr 4, 2025
Merged via the queue into main with commit 31b97f1 Apr 4, 2025
17 checks passed
@yewman yewman deleted the harnew/bpf-execution-v2 branch April 4, 2025 17:49
@github-project-automation github-project-automation bot moved this from 👀 In review to ✅ Done in Sig Apr 4, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: ✅ Done
Development

Successfully merging this pull request may close these issues.

3 participants