Add support for Doctrine ORM 3 #968
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4933137 to
d228a5c
Compare
f5b9999 to
7249222
Compare
Prometee
reviewed
Jan 14, 2025
| @@ -40,6 +40,7 @@ parameters: | |||
| - %currentWorkingDirectory%/src/Component/vendor/* | |||
|
|
|||
| ignoreErrors: | |||
| - '/Call to method type\(\) on an unknown class Doctrine\\ORM\\Mapping\\AssociationMapping./' | |||
There was a problem hiding this comment.
What about using phpstan-doctrine here?
composer require --dev phpstan/phpstan-doctrineThere was a problem hiding this comment.
no, I don't think that's the solution.
This class does not exist on doctrine orm 2.
NoResponseMate
approved these changes
Jan 14, 2025
diimpp
approved these changes
Jan 14, 2025
GSadee
approved these changes
Jan 15, 2025
|
Thank you @loic425! 🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've also tested on Sylius with Symlink (using composer repositories option)