-
-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Administration panel redesign with Bootstrap 3 #368
Conversation
❤️ Some conflicts with master I see =) |
Ye ye I will rebase. And it's responsive, the left side menu is hidden on smaller devices, it appears as the standard bootstrap responsive menu on top navbar. It has quite a lot of small glitches on mobile, needs some fixing. |
Do you need some help with that? I have some time and I love CSS =D |
@stloyd Sure, just fork it. :) |
Rebased! |
We can remove the button shadow, doesn't have to look 3d I think. |
Classy ! |
<3 |
@pjedrzejewski : very good !!! |
@pjedrzejewski Maybe add todo list what's missing etc. (in PR description or as a comment)? |
Wow, great job! |
@stloyd Will do. :) |
@pjedrzejewski Can't push to main repo, and don't want to create new PR (you have pushed code to main not to fork so GH is a bit crappy here), so here you will find mine change (WIP): https://github.com/stloyd/Sylius/tree/bootstrap-3 |
I'll simply pull your changes to this PR. Thanks! |
Very cool! +1 for less! |
This is great! 👍 |
@pjedrzejewski Additional cleanup commit: 6d3bc99ffbf18b33da2af996b8d3c7ffe68c0160 |
@stloyd Dude, help me making the sidebar |
@kayue I've removed the shadow from buttons, as you suggested! |
@winzou Good idea, I'll look into this. |
+100 for less (or sccs) ;-) So we could easily customising the color/font theme via variables |
@pjedrzejewski Here you have some fixes: 5c0bceb & 80c9357 (I'm looking now at sidebar). |
that's cool ! @stloyd can the variants be collapsed ? |
@stloyd @pjedrzejewski Great work on the backend design 👍 |
@jjanvier I was thinking on something like this, as well as about i.e. smaller dates (just Also collapsing by default is not best idea IMO. But let's see what @pjedrzejewski thinks about that. |
@stloyd Looks great. |
@jjanvier @pjedrzejewski Quick change so it's not perfect but works: |
Few additional fixes on the way.
|
@pjedrzejewski That gallery script is not compatible with Bootstrap 3 (at least it looks like that), maybe we should replace it with something simpler? |
@stloyd Yes. http://fancybox.net/, what do you think? I couldn't find anything for BS3. |
There is http://bootply.com/71401 and http://ashleydw.github.io/lightbox/ (better imo). |
I guess that lightbox could be good as it's small, but if we want something more advanced I found this: http://blueimp.github.io/Gallery/ |
Maybe https://github.com/blueimp/Gallery or https://github.com/yairEO/photobox ? |
Hello Henrik! Thanks for suggestions guys, I like http://blueimp.github.io/Gallery/, @stloyd do you have a moment for this or should I work on it? |
@pjedrzejewski Here you go: 8941ef37f15bf1c1a7f2e9a7922678898c656ef3 |
Administration panel redesign with Bootstrap 3
We'll address the minor issues in other PR's. Thanks @stloyd for help! |
I also upgraded frontend to use Bootstrap3, without any major changes to the look though. |
Woha ! That's really beautiful !! |
I have to say it: awesome work guys! Two things though:
|
Congratulations guys. |
It requires a lot of work and clean up of css (or maybe moving everything to less), but it's a good start.
Before...
After...