Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove nyholm/psr7 config #1089

Merged
merged 1 commit into from
Jan 10, 2025
Merged

Conversation

GSadee
Copy link
Member

@GSadee GSadee commented Dec 11, 2024

This config is unnecessary and relies on a package from the dev dependencies.
The http_discovery abstraction, that's in use, is configured by default and will resolve the actual services based on installed packages.

@GSadee GSadee requested a review from a team as a code owner December 11, 2024 12:10
@GSadee GSadee force-pushed the remove-nyholm-config branch from 36c77e8 to df0454f Compare December 11, 2024 14:36
@GSadee GSadee force-pushed the remove-nyholm-config branch from df0454f to d462672 Compare January 10, 2025 08:34
@GSadee GSadee requested a review from a team as a code owner January 10, 2025 08:34
@NoResponseMate NoResponseMate merged commit 93a1e6c into Sylius:2.0 Jan 10, 2025
12 checks passed
@GSadee GSadee deleted the remove-nyholm-config branch January 10, 2025 11:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants