-
-
Notifications
You must be signed in to change notification settings - Fork 880
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: minor painterro integration fixes #338
fix: minor painterro integration fixes #338
Conversation
Removing an external call to CDN is certainly something I pondered before. Do you have an idea how to serve it locally lazily? I see no benefit just bundling painterro.js along with index.js on load. |
Not sure how feasible it is, but maybe there's a way to serve these static assets (CSS and JS, including libraries, or maybe even images or fonts in the future) from a folder, more like a webserver? |
Not to my knowledge. Serving of static assets is completely blackboxed by Gradio. The only way I see to do this without bundling it is getting it separately on _js hook of clicking "Advanced Editor" button. A method similar to this that will read it from a separate file |
These changes are okay I think, everything still works at least. @altryne this is something we could ask gradio to change
|
Yep, they allow to pass Extendable gradio components is another major want. The ability to change the functionality of something like mask editor would go a long way. |
@codedealer please consdier adding those requests in Gradio repo! |
@altryne I made a general feature request gradio-app/gradio#2137. Feel free to pitch in if you have something to expand upon it. |
Advanced Editor
button is pressed rapidly before painterro has been loadedfalse