Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Border not rendered properly #491

Closed
00xBAD opened this issue Dec 31, 2018 · 4 comments
Closed

Border not rendered properly #491

00xBAD opened this issue Dec 31, 2018 · 4 comments

Comments

@00xBAD
Copy link

00xBAD commented Dec 31, 2018 •
edited
Loading

The border of terminal is not rendered correctly, all other functions seems works properly, but when i add screen curvature it render a strange border around the terminal.

Screenshots and screenfetch output to show you the issue.

Default Amber Profile
1

Monochrome Green Profile
2

IBM Dos Profile
3

I have downloaded the package from Pamac, and have this issue.
I have download dependencies, then compiled from github, but the issue is still be here.

Ask me if you need extra info from my system.
@Swordfish90
Copy link
Owner

Mmmh... It seems your gpu is not fond of the new frame shader. Could you share what's printed on stdout when launching crt? Using --verbose might be useful.

@doughsay
Copy link

doughsay commented Jan 2, 2019

I'm seeing this after the new update too; I'm also on Manjaro.

I have a GTX 1070 and am using the official Nvidia drivers (current version: 1:415.25-0)

here's the output from running crt with --verbose:

$ cool-retro-term --verbose
default KB_LAYOUT_DIR:  "/usr/lib/qt/qml/QMLTermWidget/kb-layouts"
QObject::connect: No such slot Konsole::TerminalDisplay_QML_48::close()
loadAllColorSchemes
qml: Adding system font:  Bitstream Vera Sans Mono
qml: Adding system font:  DejaVu Sans Mono
qml: Adding system font:  Droid Sans Mono
qml: Adding system font:  Fira Code
qml: Adding system font:  Fira Code Light
qml: Adding system font:  Fira Code Medium
qml: Adding system font:  Fira Code Retina
qml: Adding system font:  Fira Mono
qml: Adding system font:  Fira Mono Medium
qml: Adding system font:  Hack
qml: Adding system font:  Inconsolata
qml: Adding system font:  Liberation Mono
qml: Adding system font:  Monospace
qml: Adding system font:  Nimbus Mono PS
qml: Adding system font:  Noto Mono
qml: Adding system font:  PowerlineSymbols
qml: Adding system font:  xos4 Terminus
qml: Adding system font:  Bitstream Vera Sans Mono
qml: Adding system font:  DejaVu Sans Mono
qml: Adding system font:  Droid Sans Mono
qml: Adding system font:  Fira Code
qml: Adding system font:  Fira Code Light
qml: Adding system font:  Fira Code Medium
qml: Adding system font:  Fira Code Retina
qml: Adding system font:  Fira Mono
qml: Adding system font:  Fira Mono Medium
qml: Adding system font:  Hack
qml: Adding system font:  Inconsolata
qml: Adding system font:  Liberation Mono
qml: Adding system font:  Monospace
qml: Adding system font:  Nimbus Mono PS
qml: Adding system font:  Noto Mono
qml: Adding system font:  PowerlineSymbols
qml: Adding system font:  xos4 Terminus
file:///usr/lib/qt/qml/QtQuick/Dialogs/DefaultFileDialog.qml:102:33: QML Settings: Failed to initialize QSettings instance. Status code is: 1
file:///usr/lib/qt/qml/QtQuick/Dialogs/DefaultFileDialog.qml:102:33: QML Settings: The following application identifiers have not been set: QVector("organizationName", "organizationDomain")
Both point size and pixel size set. Using pixel size.
qml: Loading settings: {
  "fps": 0,
  "x": 55,
  "y": 56,
  "width": 1625,
  "height": 994,
  "windowScaling": 1,
  "showTerminalSize": true,
  "fontScaling": 1,
  "fontNames": [
    "TERMINUS_SCALED",
    "APPLE_II",
    "COMMODORE_PET"
  ],
  "showMenubar": false,
  "bloomQuality": 0.5,
  "burnInQuality": 0.5,
  "useCustomCommand": false,
  "customCommand": ""
}{
  "backgroundColor": "#000000",
  "fontColor": "#ff8100",
  "flickering": 0.1,
  "horizontalSync": 0.08,
  "staticNoise": 0.1198,
  "chromaColor": 0.2483,
  "saturationColor": 0.2483,
  "screenCurvature": 0.3,
  "glowingLine": 0.2,
  "burnIn": 0.2517,
  "bloom": 0.5538,
  "rasterization": 0,
  "jitter": 0.1997,
  "rbgShift": 0,
  "brightness": 0.5,
  "contrast": 0.7959,
  "ambientLight": 0.2,
  "windowOpacity": 1,
  "fontName": "TERMINUS_SCALED",
  "fontWidth": 1,
  "margin": 0.5
}

Swordfish90 added a commit that referenced this issue Jan 2, 2019
@Swordfish90
Fixes issue #491.
f2f38c0
@Swordfish90
Copy link
Owner

I've been able to reproduce the issue using a nvidia gpu. Fix commited. Thank you guys for spotting that.

eugene2candy added a commit to eugene2candy/cool-retro-term that referenced this issue Apr 10, 2021
@eugene2candy @alex-spataru
@alexmyczko @Swordfish90 @rbanffy @b0n541 @barak @probonopd @tgerczei @matthiasbalke @scruss @kz6fittycent @leereilly @suve @hroncok @maiki @haesbaert @AVHon @larsbrinkhoff @tomchiverton @picospuch @mason1920 @dagostinelli @refacto @0mp @timm0e @haradric @jayk @ayazhafiz @antler5 @titan2420
PR (#2)
4b98521 
* Save window size

* Also save window position

* Use provided settings database

* Create watch

watch file to be used by uscan(1)

* Create cool-retro-term.1

a manpage

* Update 3270 terminal font

* Updated install of needed packages for Ubuntu 16.10

* Removed duplicated packages from Ubuntu 16.10

* add comment listing bugs in --help option output

* add --version, aka -v, command line option

* typo

* version 1.0

* Create .travis.yml

* Update .travis.yml

* Install libgl-dev

* Install libgl1-mesa-dev

* Upload to transfer.sh

* Use linuxdeployqt-3-x86_64.AppImage

* -qmldir=./app/qml/ -qmldir=./qmltermwidget/

* linuxdeployqt-3-x86_64.AppImage

* Debug why some qml imports do not get deployed

* Update .travis.yml

* find /opt/qt58/ | grep QtGraphicalEffects

* Update .travis.yml

* Update .travis.yml

* Update .travis.yml

* Update .travis.yml

* Update .travis.yml

* Update .travis.yml

* Update .travis.yml

* Update .travis.yml

* Update .travis.yml

* update change log for a first upload (sponsoring)

how it should be for a first official Debian package

* Try to reduce workarounds fpr

* Use linuxdeployqt-continuous-x86_64.AppImage for now

* update copyright years

* See if we still need 2 runs

* Update .travis.yml

* fix typos

* Gentoo overlay source change note

* fixed markdown headings

* Update README.md

added Ubuntu 17.04 dependencies

* Create snapcraft.yaml

* Updated 3278 font and associated files

* Update submodule to include fix for High Sierra.

* Bump version to 1.0.1.

* Gentoo package version bump announced

* Updated OS X → macOS

* Add some GIFs?

* Make screenshot sizes in appdata XML match actual image sizes

* Improve manpage: add description and missing options, improve formatting

* cool-retro-term made it to Fedora official repos

* Instrucitons for ubuntu 17.10. Fixes Swordfish90#396

* Update readme

Periods, amirite?

* Change apt-get to apt, and added stretch.

* Add a -T option that sets window title.

`cool-retro-term -T myretrosession` sets window name to 'myretrosession'

This is useful especially for people who rely on wmctrl to change windows, now I
can do `wmctrl -a myretrocession` to focus on cool-retro-term.

-T was chosen since it matches classic xterm(1) and other terminal emulators

* add Debian Stretch to dependency instructions

I've confirmed that the same instructions for Jessie also work for Stretch

* Added Debian Stretch dependencies

In addition to what Debian Jessie needs, Stretch also needs qml-module-qt-labs-settings and qml-module-qt-labs-folderlistmodel
These packages are not needed to build cool-retro-term, but they are needed to run it.

* Add Knight TV font.  As used by the MIT AI Lab.

* Add a Knight TV profile.

* Ubuntu 17.10 PPA

* Increase baseScaling font for knight profile to improve consistency.

* Add a description of the -T option to the man page

* Fix alphabetically incorrect ordering of options in man page

* Preparing for PR.

* fix alt(meta), ctrl for emacs on macos

* update submodule

* Update snapcraft.yaml

* merging stuff

* Delete snapcraft.yaml

* Update snapcraft.yaml

* Update snapcraft.yaml

* Update snapcraft.yaml

* Update snapcraft.yaml

* Update snapcraft.yaml

* Update with v2.0.0 - new glyphs, better hinting

* Update README.md

* Track unstable qmltermwidget branch.

* Initial support for system monospace fonts.

* Slight improvements to burnin and rgb shift effects.

* Fix wrong bottom texture clamping.

* Slight improvements to brunin look.

* Update and replace fonts.

* Fix some alignment related warnings.

* RGB Shift effect now looks much better.

* Improve bloom effect. This is more pronounced in very bright areas.

* Add subpixels rasterization and improve existing ones.

* Further improve rgbShift effect. Now can be enabled without chroma color.

* Slightly change rgb shift values.

* Fix wrong gamma colors when using chroma.

* Important burn-in optimization. It is much lighter on resources.

* Unload burnin effect when not in use.

* Fix masking issue with new burn in.

* Make jitter stronger on the x axis.

* Fix screen brightness consistency in some scenarios.

* Fix small issue with burnin masking.

* Fix division by zero when no effects were selected.

* Change mask value to use greyscale color instead of max channel.

* Revert "Add subpixels rasterization and improve existing ones."

Use something similar to what we had before, avoiding heavy texture
fetches."

This reverts commit 293b05f.

* Update snapcraft.yaml

* Update snapcraft.yaml

* Reduce default font size.

* Make font sizes more consistent.

* Increase maximum amount of bloom allowed.

* Update snapcraft.yaml

* Update snapcraft.yaml

* Scanlines no longer affect background. Less artifacts at low fontSize values.

* Update terminus font.

* Handle db upgrades and prepare work for old profiles deprecation.

* Update snapcraft.yaml

* Revert "Handle db upgrades and prepare work for old profiles deprecation."

This reverts commit 6fb8ceb.

* Handle database and profile upgrade for new versions.

* Fix a couple of issues with burnIn.

* Update snapcraft.yaml

* Avoid border artifacts on burn in effect.

* Hide by default menubar on linux.

* Limit screen curvature effect.

* Fixed fontColor conversion applied two times.

* Update README.md

Make it easier for the eye to pick up the instructions for the various Linux distros.  Presently, the eye skips over them and all you see are the Ubuntu things.  Also adjusted the help text a little.

* Update defualt profiles.

* Custom command should be a setting not a profile.

* Bump version code.

* Update qmltermwidget submodule.

* Change version and description of snap package.

* First implementation of imageless frame.

* Add inner screen shadow. Various overall frame improvements.

* Remove useless frame settings.

* First wrong framebuffer implementation.

* Use window scaling parameter for framebuffer size.

* Split effects into static (cached) and dynamic computed at every frame.

* Reduce default fps to 20. It looks good with new burnin and saves some gpu.

* Rearrange settings window.

* Tweak some shader constants.

* Change default curvature values.

* Unload frame when not needed.

* Move frame to separate framebuffer. This fixes some glitches in terminal
frame.

* Allow screen margin customization.

* Improve settings layout.

* Force integer values for new margins.

* Let's reenable smoothing in burnin to see which artifact is actually better.

* Remove comment.

* Change the way margin is used. This slightly improves quality.

* Change burnin masking function to max. Should preseve darker colors.

* Reduce horizontal sync maximum strength.

* Revert "Change burnin masking function to max. Should preseve darker colors."

This reverts commit 3cee186.

* Reduce horizontal sync possible minimum value.

* Update README.md

* new ebuild available for 1.1.0

* Fixes issue Swordfish90#491.

* Fix Swordfish90#336

* Upload to GitHub Releases

Need to set a GITHUB_TOKEN environment variable in https://travis-ci.org/Swordfish90/cool-retro-term/settings

* usr/share/metainfo

As per https://www.freedesktop.org/software/appstream/docs/chap-Quickstart.html#sect-Quickstart-DesktopApps, usr/share/metainfo should be used

* correct version number output with --version

* Settings optin for old burinin version. It seems to be working better on osx.

* Improve highdpi support.

* Use threaded renderer by default in linux. This improves performances.

* Use a single version name.

* Fix font slider misbehaving.

* Bump version number.

* Update snapcraft file.

* Update snap package to use core18.

* Fix snap package launcher and expose in path qml directory.

* Print system font log only when verbose is enabled.

* Update README.md

* Remove snapcraft plugs. Not used for classic confinement.

* Adds installation instruction for Solus

* Add FreeBSD installation instructions

* Fix typo in README.md

* Add two missing qt dependencies to snapcraft.yaml

* new ebuild available for 1.1.1

* Update README.md

added installation method via Hombrew

* Update qmltermwidget submodule with CTRL+SPACE fix.

* Update qmltermwidget submodule

* Add support for blinking cursor

* Disable blinking cursor by default

* Update Readme - Trizen for Arch - Yaourt is deprecated.

yaourt is deprecated.  Use trizen instead.  The command line arguments are identical to yaourt, for easy migration.

* Add installation instructions using Homebrew

I was not aware there was a [Homebrew cask](https://github.com/Homebrew/homebrew-cask/blob/master/Casks/cool-retro-term.rb) for this
project, which simplifies installation on macOS. This commit adds
documentation for installing the app via Homebrew.

* now packaged in the official repository

* Update Readme.md to include directions to settings

Several users of OS's without titlebars or window decor have expressed confusion at how one change's their theme (in this case, via the context menu). Mentioning how to access the menu in the Readme will make the settings more accessible and prevent any future confusion. It might be more appropriate to create a "Use" heading exploring features such as Performance settings, but for the sake of brevity, I've just inserted a mention at the end of the description, before more OS-specific install instructions.

* Adding snap install method

Adding snap install method which is supported in most of the distros and is easy!

* git ignore app/moc_predefs.h

* squelch ugly quotes on 1st line of cool-retro-term --usage

* send cool-retro-term --help and --version to stdout

* allow --help/-h/--version/-v options without graphics

* Bump qmltermwidget submodule.

Co-authored-by: Alex Spataru <alex_spataru@outlook.com>
Co-authored-by: Alex <alex@aiei.ch>
Co-authored-by: Filippo Scognamiglio <flscogna@gmail.com>
Co-authored-by: Ricardo Banffy <rbanffy@gmail.com>
Co-authored-by: Jan Schäfer <j@nschaefer.net>
Co-authored-by: Barak A. Pearlmutter <barak+git@pearlmutter.net>
Co-authored-by: probonopd <probonopd@users.noreply.github.com>
Co-authored-by: Tamás Gérczei <tamas@gerczei.eu>
Co-authored-by: Matthias Balke <matthias.balke@googlemail.com>
Co-authored-by: Stewart C. Russell <scruss@scruss.com>
Co-authored-by: kz6fittycent <jimmy.tigert@gmail.com>
Co-authored-by: Filippo Scognamiglio <filippo.scognamiglio@funambol.com>
Co-authored-by: Lee Reilly <lee@github.com>
Co-authored-by: suve <veg@svgames.pl>
Co-authored-by: Miro Hrončok <miro@hroncok.cz>
Co-authored-by: Lars Falk-Petersen <lars.falk-petersen@copyleft.no>
Co-authored-by: maiki <maiki@interi.org>
Co-authored-by: mason1920 <mkukosky@outlook.com>
Co-authored-by: Christiano Haesbaert <haesbaert@haesbaert.org>
Co-authored-by: Alex Von Hoene <avh.on1@gmail.com>
Co-authored-by: Lars Brinkhoff <lars@nocrew.org>
Co-authored-by: Tom Chiverton <tomchiverton@users.noreply.github.com>
Co-authored-by: spuch <picospuch@gmail.com>
Co-authored-by: mason1920 <42262007+mason1920@users.noreply.github.com>
Co-authored-by: Darryl T. Agostinelli <dagostinelli@users.noreply.github.com>
Co-authored-by: Sascha Paunovic <azarus@posteo.net>
Co-authored-by: mclang <Jani.Long@gmail.com>
Co-authored-by: Mateusz Piotrowski <0mp@FreeBSD.org>
Co-authored-by: timm0e <11885527+timm0e@users.noreply.github.com>
Co-authored-by: Haradric <nikita.braslavskiy@gmail.com>
Co-authored-by: Kristian <ga53jey@mytum.de>
Co-authored-by: Jay Kuri <jayk@ionzero.com>
Co-authored-by: ayazhafiz <ayaz.hafiz.1@gmail.com>
Co-authored-by: AutumnalAntlers <45282916+AutumnalAntlers@users.noreply.github.com>
Co-authored-by: Amir Fo <pwwiur@yahoo.com>
@acc3ssd
Copy link

acc3ssd commented Jan 21, 2025

I've been having a similar issue using cool-retro-term 1.2 installed from the Ubuntu repositories (see attached screenshot). The Snap version works fine, but is out of date. I'm running Ubuntu 24.10 with an NVIDIA GeForce RTX 4070 SUPER graphics card. Any idea how to fix it?

Image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@doughsay @Swordfish90 @00xBAD @acc3ssd