feat(app): add sentry to git clone #963
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Ralf Grubenmann <ralf.grubenmann@protonmail.com>
Co-authored-by: Ralf Grubenmann <ralf.grubenmann@gmail.com>
olevski
commented
Mar 21, 2022
| @@ -106,6 +106,22 @@ spec: | |||
| value: {{ .Values.sentry.sampleRate | quote }} | |||
| - name: SENTRY_RELEASE | |||
| value: {{ .Chart.Version | quote }} | |||
| - name: GIT_CLONE_SENTRY_ENABLED | |||
There was a problem hiding this comment.
@Panaetius we do not need double underscores here. This is just injected into the notebook service container.
The notebook service then uses these environment variables and patches them into the session. Once things are patched into the sessions they need to have the double underscores so that they can be parsed by dataconf.
Here I did not add any double underscores because we do not use dataconf at this level yet.
There was a problem hiding this comment.
The failing integration tests were a fluke. I reran them locally too without a problem.
Panaetius
approved these changes
Mar 22, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should be reviewed and merged after #956 is merged.
This adds the possibility to add separate sentry trackers for the init container in every sessions that clones and for the sidecar rpc server container which (among other things) creates the autosave.
Because these are completely different environments than the renku-notebooks flask server I added separate projects for them. And the values file enables people to add separate sentry dsn for each container. I think this makes sense rather than seeing everything lumped in one. This way the errors from the flask server and any number of sessions always have to be combined in the same sentry project. This way we have flexibility to make them the same (by providing the same dsn in all places) or not.
In addition it is possible that some people may not want to add sentry in user sessions but may want to do so in the notebook server.
I caused the autosave creation and cloning to fail artificially and the errors show up:
https://sentry.dev.renku.ch/organizations/sentry/issues/415/?project=10
https://sentry.dev.renku.ch/organizations/sentry/issues/414/?project=11
closes #376