Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add anti-affinity to stateful set #915

Merged
merged 5 commits into from
Feb 9, 2022

Conversation

Panaetius
Copy link
Member

@Panaetius Panaetius commented Feb 8, 2022

closes #820

/deploy #persist

@olevski
Copy link
Member

olevski commented Feb 8, 2022

@Panaetius I checked and when the keys are duplicated then the one key later in the file is the one used. So the way that you have set things up things should work.

Ralf Grubenmann added 2 commits February 9, 2022 14:24
…cienceCenter/renku-notebooks into feature/820-pod-anti-affinity
@Panaetius Panaetius deployed to renku-ci-nb-915 February 9, 2022 13:27 Active
@RenkuBot
Copy link
Contributor

RenkuBot commented Feb 9, 2022

You can access the deployment of this PR at https://renku-ci-nb-915.dev.renku.ch

@olevski olevski marked this pull request as ready for review February 9, 2022 13:36
@olevski olevski requested a review from a team as a code owner February 9, 2022 13:36
@olevski olevski self-requested a review February 9, 2022 13:36
Copy link
Member

@olevski olevski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can confirm in the CI deployment that this is working as expected:

renku-ci-nb-915-notebooks-0                            1/1     Running     0          2m35s   10.42.13.25    worker-dev.renku-fat-nodes-2   <none>           <none>
renku-ci-nb-915-notebooks-1                            1/1     Running     0          98s     10.42.3.27     worker-dev.renku-default-6     <none>           <none>

@olevski
Copy link
Member

olevski commented Feb 9, 2022

I cannot replicate the previous failure of the integration tests. I think it was caused by some changes happening in the infra at the time where most of the nodes were scaled down a lot and it was hard to schedule things. Rerunning the tests cleared this.

In addition the acceptance tests fail on starting an anonymous session. I tested this in the CI deployment and things work as expected - so it is just a fluke. I can launch an anonymous sessions without a problem.

@olevski olevski merged commit 67b3b80 into master Feb 9, 2022
@olevski olevski deleted the feature/820-pod-anti-affinity branch February 9, 2022 16:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add anti-affinity to renku-notebooks pods
3 participants