feat: save storage secrets #1927
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
You can access the deployment of this PR at https://renku-ci-nb-1927.dev.renku.ch |
e9ae4e2 to
6abac17
Compare
6916eba to
3f874e2
Compare
defd23b to
b0e75ee
Compare
b0e75ee to
1ccaa7e
Compare
Panaetius
requested changes
Jul 16, 2024
renku_notebooks/api/notebooks.py
Outdated
| _on_error(f"User secret could not be created {response.json()}") | ||
| try: | ||
| response = requests.post( | ||
| config.user_secrets.secrets_storage_service_url + "/api/secrets/kubernetes", |
There was a problem hiding this comment.
suggestion: As this is used in 2 places now, we should make the path some constant defined maybe at the top of the file?
There was a problem hiding this comment.
I've refactored the duplicate code into a function.
Panaetius
approved these changes
Aug 5, 2024
olevski
pushed a commit
to SwissDataScienceCenter/renku-data-services
that referenced
this pull request
Dec 10, 2024
olevski
pushed a commit
to SwissDataScienceCenter/renku-data-services
that referenced
this pull request
Dec 19, 2024
olevski
pushed a commit
to SwissDataScienceCenter/renku-data-services
that referenced
this pull request
Dec 19, 2024
olevski
pushed a commit
to SwissDataScienceCenter/renku-data-services
that referenced
this pull request
Dec 20, 2024
olevski
pushed a commit
to SwissDataScienceCenter/renku-data-services
that referenced
this pull request
Dec 20, 2024
olevski
added a commit
to SwissDataScienceCenter/renku-data-services
that referenced
this pull request
Dec 23, 2024
Migrating SwissDataScienceCenter/renku-notebooks#1927 * feat: no http calls to data svc for cloud storage --------- Co-authored-by: Mohammad Alisafaee <mohammad.alisafaee@epfl.ch> Co-authored-by: Flora Thiebaut <flora.thiebaut@sdsc.ethz.ch>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
/deploy renku-data-services=pitch/save-storage-credentials-save-secrets renku-ui=ciyer/storage-secrets-storage extra-values=csi-rclone.csiControllerRclone.rclone.image.repository=mohammadsdsc/csi-rclone,csi-rclone.csiControllerRclone.rclone.image.tag=v0.1.8-0.dev.git.102.hb496bd0,csi-rclone.csiNodepluginRclone.rclone.image.repository=mohammadsdsc/csi-rclone,csi-rclone.csiNodepluginRclone.rclone.image.tag=v0.1.8-0.dev.git.102.hb496bd0,global.csi-rclone.install=true,csi-rclone.storageClassName=test-csi-rclone,notebooks.cloudstorage.storageClass=test-csi-rclone,csi-rclone.csiNodepluginRclone.tolerations[0].key=CriticalAddonsOnly,csi-rclone.csiNodepluginRclone.tolerations[0].operator=Exists,csi-rclone.csiNodepluginRclone.tolerations[1].effect=NoSchedule,csi-rclone.csiNodepluginRclone.tolerations[1].key=nvidia.com/gpu,csi-rclone.csiNodepluginRclone.tolerations[1].operator=Exists,csi-rclone.csiNodepluginRclone.tolerations[2].effect=NoSchedule,csi-rclone.csiNodepluginRclone.tolerations[2].key=renku.io/dedicated,csi-rclone.csiNodepluginRclone.tolerations[2].operator=Equal,csi-rclone.csiNodepluginRclone.tolerations[2].value=user