Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: patching wrong environment variables when resuming #1923

Merged

Conversation

olevski
Copy link
Member

@olevski olevski commented Jun 26, 2024

Fixes #1921.

Reported by a user. The wrong environment variable was patches when the session was hibernated and the access tokens were expired.

/deploy

@olevski olevski requested a review from a team as a code owner June 26, 2024 13:59
Fixes #1921. Reported by a user. The wrong environment variable was
patches when the session was hibernated and the access tokens were
expired.
@olevski olevski force-pushed the fix-1921-do-not-overwrite-jupyter-config-when-resuming branch from 5944370 to 2ed4482 Compare June 26, 2024 14:00
@RenkuBot
Copy link
Contributor

You can access the deployment of this PR at https://renku-ci-nb-1923.dev.renku.ch

@olevski olevski merged commit 1c9204b into master Jul 1, 2024
21 checks passed
@olevski olevski deleted the fix-1921-do-not-overwrite-jupyter-config-when-resuming branch July 1, 2024 07:57
olevski added a commit to SwissDataScienceCenter/renku-data-services that referenced this pull request Dec 10, 2024
olevski added a commit to SwissDataScienceCenter/renku-data-services that referenced this pull request Dec 19, 2024
olevski added a commit to SwissDataScienceCenter/renku-data-services that referenced this pull request Dec 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Resuming a hibernated session with secrets fails start
3 participants