feat: support connected services #1874
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add support to mount repositories from external sources in session. This requires `connected services` support from `renku-data-services`. Also, the API for starting Renku 2.0 sessions has been modified to accept external repositories. Changes in `notebooks`: * Refactored the `UserServer` class to be an abstract class. `Renku1UserServer` and `Renku2UserServer` inherit from `UserServer` and contain the corresponding adaptations needed to support Renku 1.0 and Renku 2.0 sessions respectively. * Changed the `amalthea` patches to reflect changes in `git-clone` and `git-proxy`. * Updated the `patch_statefulset_tokens()` method invoked when resuming sessions. Changes in `git-clone`: * Refactored the `git-clone` container to support cloning repositories from any source. * Cloning is done optimistically. The `git-clone` container will not crash if a repository cannot be cloned. * For private repositories, a `git provider` must be configured and will be used to clone. * The container now only uses the `renku_access_token`. Changes in `git-proxy`: * Refactored the `git-proxy` container to support injecting credentials from external services. * The `git-proxy` is a simple pass-through for anonymous sessions (meaning it should probably not run for anonymous sessions). * Repositories matching a configured `git provider` will have credentials injected: - From `renku-gateway-auth` for the internal GitLab - From `renku-data-services` for other services * The container now only uses the `renku_access_token` and the `renku_refresh_token`.
Merge changes from `master`.
…vices-final # Conflicts: # git_services/git_services/init/cloner.py # git_services/git_services/init/config.py # git_services/git_services/sidecar/errors.py # renku_notebooks/api/amalthea_patches/inject_certificates.py # renku_notebooks/api/classes/data_service.py # renku_notebooks/api/classes/k8s_client.py # renku_notebooks/api/classes/server.py # renku_notebooks/api/notebooks.py # renku_notebooks/api/schemas/repository.py # renku_notebooks/config/__init__.py # renku_notebooks/util/kubernetes_.py # tests/unit/test_server_class/test_manifest.py
3 tasks
Panaetius
previously approved these changes
May 16, 2024
Panaetius
approved these changes
May 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add support to mount repositories from external sources in session. This requires
connected servicessupport fromrenku-data-services. Also, the API for starting Renku 2.0 sessions has been modified to accept external repositories.Changes in
notebooks:UserServerclass to be an abstract class.Renku1UserServerandRenku2UserServerinherit fromUserServerand contain the corresponding adaptations needed to support Renku 1.0 and Renku 2.0 sessions respectively.amaltheapatches to reflect changes ingit-cloneandgit-proxy.patch_statefulset_tokens()method invoked when resuming sessions.Changes in
git-clone:git-clonecontainer to support cloning repositories from any source.git-clonecontainer will not crash if a repository cannot be cloned.git providermust be configured and will be used to clone.renku_access_token.Changes in
git-proxy:git-proxycontainer to support injecting credentials from external services.git-proxyis a simple pass-through for anonymous sessions (meaning it should probably not run for anonymous sessions).git providerwill have credentials injected:renku-gateway-authfor the internal GitLabrenku-data-servicesfor other servicesrenku_access_tokenand therenku_refresh_token.