Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: custom culling times #1852

Merged
merged 10 commits into from
May 22, 2024
Merged

feat: custom culling times #1852

merged 10 commits into from
May 22, 2024

Conversation

Panaetius
Copy link
Member

@Panaetius Panaetius commented Apr 26, 2024 •
edited by lorenzo-cavazzi
Loading

/deploy renku=release-0.52.x renku-data-services=main renku-ui=custom-culling-times

@Panaetius Panaetius marked this pull request as ready for review April 29, 2024 13:41
@Panaetius Panaetius requested a review from a team as a code owner April 29, 2024 13:41
@Panaetius Panaetius force-pushed the custom-culling-times branch from 61d27e9 to 30cecda Compare April 30, 2024 14:13
@Panaetius Panaetius force-pushed the custom-culling-times branch from 30cecda to 39d6c85 Compare May 2, 2024 09:09
olevski
olevski requested changes May 16, 2024
View reviewed changes
Copy link
Member

@olevski olevski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good just a few minor renamings and clarifications.

renku_notebooks/api/classes/data_service.py Outdated Show resolved Hide resolved
renku_notebooks/api/notebooks.py Outdated Show resolved Hide resolved
renku_notebooks/api/schemas/server_options.py Outdated Show resolved Hide resolved
@olevski olevski self-requested a review May 16, 2024 11:25
olevski
olevski previously approved these changes May 16, 2024
View reviewed changes
@RenkuBot
Copy link
Contributor

You can access the deployment of this PR at https://renku-ci-nb-1852.dev.renku.ch

@Panaetius Panaetius force-pushed the custom-culling-times branch from 1d3147a to 6902510 Compare May 16, 2024 17:32
@Panaetius Panaetius temporarily deployed to renku-ci-nb-1852 May 16, 2024 17:36 — with GitHub Actions Inactive
@Panaetius Panaetius temporarily deployed to renku-ci-nb-1852 May 16, 2024 20:29 — with GitHub Actions Inactive
@Panaetius Panaetius requested a review from olevski May 16, 2024 20:29
@Panaetius Panaetius temporarily deployed to renku-ci-nb-1852 May 17, 2024 06:29 — with GitHub Actions Inactive
@Panaetius Panaetius temporarily deployed to renku-ci-nb-1852 May 17, 2024 12:30 — with GitHub Actions Inactive
@Panaetius Panaetius temporarily deployed to renku-ci-nb-1852 May 21, 2024 08:02 — with GitHub Actions Inactive
@Panaetius Panaetius merged commit 4303bb9 into master May 22, 2024
16 checks passed
@Panaetius Panaetius deleted the custom-culling-times branch May 22, 2024 11:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@olevski olevski olevski approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Panaetius @RenkuBot @olevski @lorenzo-cavazzi