Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(sidecar): anon users clone repo at correct SHA #1406

Merged
merged 2 commits into from
Feb 15, 2023
Merged

fix(sidecar): anon users clone repo at correct SHA #1406

merged 2 commits into from
Feb 15, 2023

Conversation

olevski
Copy link
Member

@olevski olevski commented Feb 15, 2023 •
edited
Loading

If an anonymous user requests a session at a commit sha other than head then they would always get head.

This happened only for anonymous sessions. This fixes the problem.

/deploy #persist

@olevski olevski requested a review from a team as a code owner February 15, 2023 14:36
@olevski olevski marked this pull request as draft February 15, 2023 14:36
@olevski olevski temporarily deployed to renku-ci-nb-1406 February 15, 2023 14:36 — with GitHub Actions Inactive
@olevski
Copy link
Member Author

olevski commented Feb 15, 2023

Thanks @lorenzo-cavazzi for reporting.

@RenkuBot
Copy link
Contributor

You can access the deployment of this PR at https://renku-ci-nb-1406.dev.renku.ch

lorenzo-cavazzi
lorenzo-cavazzi approved these changes Feb 15, 2023
View reviewed changes
Copy link
Member

@lorenzo-cavazzi lorenzo-cavazzi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It works well with this fix 👍

@olevski olevski marked this pull request as ready for review February 15, 2023 16:54
@olevski olevski deployed to renku-ci-nb-1406 February 15, 2023 16:55 — with GitHub Actions Active
@olevski olevski merged commit 63d734b into master Feb 15, 2023
@olevski olevski deleted the fix-correct-sha-for-anonymous-user branch February 15, 2023 21:42
@Panaetius Panaetius mentioned this pull request May 15, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lorenzo-cavazzi lorenzo-cavazzi lorenzo-cavazzi approved these changes

@Panaetius Panaetius Panaetius approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@olevski @RenkuBot @Panaetius @lorenzo-cavazzi