Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(sidecar): renku needs to be on path #1293

Merged
merged 2 commits into from
Oct 5, 2022
Merged

fix(sidecar): renku needs to be on path #1293

merged 2 commits into from
Oct 5, 2022

Conversation

olevski
Copy link
Member

@olevski olevski commented Sep 28, 2022 •
edited
Loading

There were some issues running renku cli commands from within the git rpc sidecar.

These were the result of:

  • the python git library used by renku trying to use bash and the alpine images not having bash by default, after installing bash in the image (which added only 1MB to the size) I did not see this again
  • the renku cli not being on the path - after I adjusted the path for the image everything works

cc @ciyer

@olevski olevski requested a review from a team as a code owner September 28, 2022 11:40
ciyer
ciyer approved these changes Oct 5, 2022
View reviewed changes
Copy link
Contributor

@ciyer ciyer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this, this fixes the problems I was encountering.

@olevski olevski merged commit 978cd24 into master Oct 5, 2022
@olevski olevski deleted the fix-rpc-renku-command branch October 5, 2022 12:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ciyer ciyer ciyer approved these changes

@Panaetius Panaetius Panaetius approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@olevski @Panaetius @ciyer