Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use user credentials for pulling private images #105

Closed
ableuler opened this issue Feb 8, 2019 · 0 comments · Fixed by #327
Closed

Use user credentials for pulling private images #105

ableuler opened this issue Feb 8, 2019 · 0 comments · Fixed by #327
Assignees
@rokroskar
Milestone
sprint-2020-05-28

Comments

@ableuler
Copy link
Contributor

ableuler commented Feb 8, 2019

Currently the gitlab sudo token is still used for pulling private images. Instead we should use the users credentials. Once this is done, the gitlab sudo token is not used anymore and can thus be removed from the renku chart.
@ableuler ableuler changed the title Use user credential for pulling private images Use user credentials for pulling private images Feb 8, 2019
@rokroskar rokroskar transferred this issue from SwissDataScienceCenter/renku Feb 8, 2019
@rokroskar rokroskar added this to the 0.5.0 milestone Jun 13, 2019
@rokroskar rokroskar removed this from the 0.5.0 milestone Jul 11, 2019
@rokroskar rokroskar added this to the sprint-2019-09-09 milestone Sep 9, 2019
@lorenzo-cavazzi lorenzo-cavazzi removed this from the sprint-2019-10-03 milestone Mar 5, 2020
@rokroskar rokroskar self-assigned this Jun 8, 2020
@rokroskar rokroskar added this to the sprint-2020-05-28 milestone Jun 8, 2020
rokroskar added a commit that referenced this issue Jun 8, 2020
@rokroskar
feat: use the user's credentials for pulling images
4e9fb91 
closes #105
@rokroskar rokroskar mentioned this issue Jun 8, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rokroskar rokroskar

Labels
None yet
Projects
None yet
Milestone
sprint-2020-05-28
Development

Successfully merging a pull request may close this issue.

use user credentials for pulling images SwissDataScienceCenter/renku-notebooks
3 participants
@rokroskar @ableuler @lorenzo-cavazzi