Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: rebase patching, set refresh tokens & priority class #592

Merged
merged 8 commits into from
Jan 21, 2025
Merged

fix: rebase patching, set refresh tokens & priority class #592

merged 8 commits into from
Jan 21, 2025

Conversation

olevski
Copy link
Member

@olevski olevski commented Dec 25, 2024

/deploy

@olevski olevski requested a review from a team as a code owner December 25, 2024 15:51
@olevski olevski marked this pull request as draft December 25, 2024 15:51
@RenkuBot
Copy link
Contributor

You can access the deployment of this PR at https://renku-ci-ds-592.dev.renku.ch

@coveralls
Copy link

coveralls commented Dec 25, 2024 •
edited
Loading

Pull Request Test Coverage Report for Build 12883872312

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

  • 84 of 294 (28.57%) changed or added relevant lines in 7 files are covered.
  • 3 unchanged lines in 2 files lost coverage.
  • Overall coverage decreased (-0.5%) to 86.504%
Changes Missing Coverage Covered Lines Changed/Added Lines %
components/renku_data_services/notebooks/crs.py 18 19 94.74%
components/renku_data_services/notebooks/config/dynamic.py 6 8 75.0%
components/renku_data_services/notebooks/api/classes/k8s_client.py 2 11 18.18%
components/renku_data_services/notebooks/utils.py 2 11 18.18%
components/renku_data_services/notebooks/models.py 12 30 40.0%
components/renku_data_services/notebooks/blueprints.py 5 32 15.63%
components/renku_data_services/notebooks/core_sessions.py 39 183 21.31%
Files with Coverage Reduction New Missed Lines %
components/renku_data_services/notebooks/blueprints.py 1 58.75%
components/renku_data_services/storage/blueprints.py 2 95.69%
Totals Coverage Status
Change from base Build 12883631578: -0.5%
Covered Lines: 15370
Relevant Lines: 17768
💛 - Coveralls

@olevski olevski force-pushed the fix-session-patching branch from 5010e37 to 5f84116 Compare December 26, 2024 00:30
@olevski olevski marked this pull request as ready for review December 27, 2024 14:39
@Panaetius
Copy link
Member

This PR seems to contain several changes unrelated to the PR title. Please update the title to be more accurate or split into multiple PRs.

@olevski olevski force-pushed the fix-session-patching branch from c1661e0 to ca9f402 Compare January 20, 2025 07:37
@olevski olevski changed the title fix: refresh git proxy tokens when patching amalthea sessions fix: rebase, set refresh tokens, priority class when patching Jan 20, 2025
@olevski olevski temporarily deployed to renku-ci-ds-592 January 20, 2025 07:40 — with GitHub Actions Inactive
@olevski olevski changed the title fix: rebase, set refresh tokens, priority class when patching fix: rebase patching, set refresh tokens & priority class Jan 20, 2025
@olevski olevski temporarily deployed to renku-ci-ds-592 January 20, 2025 08:09 — with GitHub Actions Inactive
@olevski olevski force-pushed the fix-session-patching branch from ca9f402 to a15984a Compare January 20, 2025 08:15
@olevski olevski temporarily deployed to renku-ci-ds-592 January 20, 2025 08:16 — with GitHub Actions Inactive
@olevski
Copy link
Member Author

olevski commented Jan 20, 2025

This PR seems to contain several changes unrelated to the PR title. Please update the title to be more accurate or split into multiple PRs.

I renamed it.

@olevski olevski force-pushed the fix-session-patching branch from a15984a to cb3f0b4 Compare January 21, 2025 07:37
@olevski olevski temporarily deployed to renku-ci-ds-592 January 21, 2025 07:37 — with GitHub Actions Inactive
@olevski olevski enabled auto-merge (squash) January 21, 2025 09:25
@olevski olevski merged commit cb23256 into main Jan 21, 2025
15 of 18 checks passed
@olevski olevski deleted the fix-session-patching branch January 21, 2025 09:38
@RenkuBot
Copy link
Contributor

Tearing down the temporary RenkuLab deplyoment for this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Panaetius Panaetius Panaetius approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@olevski @RenkuBot @coveralls @Panaetius