This repository has been archived by the owner on Jun 1, 2023. It is now read-only.
Bring back links to other symbols in declarations #277
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mattt
reviewed
May 18, 2021
Changelog.md
Outdated
Comment on lines
18
to
20
| - Fixed bug that caused operator implementations to appear in the documentation | ||
| although they should be omitted because of their lower access level. | ||
| #264 by @Lukas-Stuehrk |
There was a problem hiding this comment.
Suggested change
| - Fixed bug that caused operator implementations to appear in the documentation | |
| although they should be omitted because of their lower access level. | |
| #264 by @Lukas-Stuehrk | |
| - Fixed links to type declarations. | |
| #277 by @Lukas-Stuehrk. | |
| - Fixed bug that caused operator implementations to appear in the documentation | |
| although they should be omitted because of their lower access level. | |
| #264 by @Lukas-Stuehrk |
mattt
approved these changes
Jun 1, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previous versions of
swift-dochad a feature which automatically linked other symbols in the declaration of a symbol. This got removed with the changes introduced in #204. I think this is a very useful feature and it seems to be used as the discussion in #177 shows.This pull requests adds this feature again. It also includes the changes of #264 because it builds upon some changes which were already included there. Because of this, we should merge #264 first before we tackle this pull request.