-
Notifications
You must be signed in to change notification settings - Fork 0
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
- Loading branch information
Showing
64 changed files
with
442 additions
and
501 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,42 @@ | ||
## 작업내용 | ||
<!-- 작업 내용과 이미지를 첨부해주세요. --> | ||
- [x] 작업 내용 | ||
|
||
<!-- (+스크린샷)이 있다면 적어주세요. 없으면 지워주세요--> | ||
|작업 전|작업 후| | ||
|:---:|:---:| | ||
|<img width="250" src="">|<img width="250" src="">| | ||
|
||
## 리뷰포인트 | ||
<!-- 리뷰가 필요한 포인트와 해당 되는 커밋을 링크로 걸어주세요. --> | ||
|
||
## Reference | ||
<!-- 참고한 자료를 작성해주세요 --> | ||
|
||
## Motivation 🥳 (코드를 추가/변경하게 된 이유) | ||
|
||
## Key Changes 🔥 (주요 구현/변경 사항) | ||
|
||
## ToDo 📆 (남은 작업) | ||
- [ ] todo | ||
|
||
## ScreenShot 📷 (참고 사진) | ||
|
||
## To Reviewers 🙏 (리뷰어에게 전달하고 싶은 말) | ||
|
||
## Reference 🔗 | ||
|
||
## Close Issues 🔒 (닫을 Issue) | ||
Close #No. | ||
|
||
## Checklist | ||
- [ ] 브랜치를 가져와 작업한 경우 이전 브랜치에 PR을 보냈는지 확인 | ||
- [ ] 빌드를 위해 SceneDelegate 수정한 것 PR로 올리지 않았는지 확인 | ||
- [ ] 필요없는 주석, 프린트문 제거했는지 확인 | ||
- [ ] 컨벤션 지켰는지 확인 | ||
- [ ] final, private 제대로 넣었는지 확인 | ||
- [ ] 다양한 디바이스에 레이아웃이 대응되는지 확인 | ||
- [ ] iPhone SE | ||
- [ ] iPhone 13 | ||
- [ ] iPhone 13 Pro Max | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,13 @@ | ||
addReviewers: true | ||
|
||
# Set to true to add assignees to pull requests | ||
addAssignees: author | ||
|
||
# A list of reviewers to be added to pull requests (GitHub user name) | ||
reviewers: | ||
- Roy | ||
- Byeon Jinha | ||
|
||
# A number of reviewers added to the pull request | ||
# Set 0 to add all the reviewers (default: 0) | ||
numberOfReviewers: 0 |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,44 @@ | ||
name: iOS starter workflow | ||
|
||
on: | ||
push: | ||
branches: [ "Dev" ] | ||
pull_request: | ||
branches: [ "Dev" ] | ||
|
||
jobs: | ||
build: | ||
name: Build and Test default scheme using any available iPhone simulator | ||
runs-on: macos-latest | ||
|
||
steps: | ||
- name: Checkout | ||
uses: actions/checkout@v3 | ||
- name: Set Default Scheme | ||
run: | | ||
scheme_list=$(xcodebuild -list -json | tr -d "\n") | ||
default=$(echo $scheme_list | ruby -e "require 'json'; puts JSON.parse(STDIN.gets)['project']['targets'][0]") | ||
echo $default | cat >default | ||
echo Using default scheme: $default | ||
- name: Build | ||
env: | ||
scheme: ${{ 'default' }} | ||
platform: ${{ 'iOS Simulator' }} | ||
run: | | ||
# xcrun xctrace returns via stderr, not the expected stdout (see https://developer.apple.com/forums/thread/663959) | ||
device=`xcrun xctrace list devices 2>&1 | grep -oE 'iPhone.*?[^\(]+' | head -1 | awk '{$1=$1;print}' | sed -e "s/ Simulator$//"` | ||
if [ $scheme = default ]; then scheme=$(cat default); fi | ||
if [ "`ls -A | grep -i \\.xcworkspace\$`" ]; then filetype_parameter="workspace" && file_to_build="`ls -A | grep -i \\.xcworkspace\$`"; else filetype_parameter="project" && file_to_build="`ls -A | grep -i \\.xcodeproj\$`"; fi | ||
file_to_build=`echo $file_to_build | awk '{$1=$1;print}'` | ||
xcodebuild build-for-testing -scheme "$scheme" -"$filetype_parameter" "$file_to_build" -destination "platform=$platform,name=$device" | ||
- name: Test | ||
env: | ||
scheme: ${{ 'default' }} | ||
platform: ${{ 'iOS Simulator' }} | ||
run: | | ||
# xcrun xctrace returns via stderr, not the expected stdout (see https://developer.apple.com/forums/thread/663959) | ||
device=`xcrun xctrace list devices 2>&1 | grep -oE 'iPhone.*?[^\(]+' | head -1 | awk '{$1=$1;print}' | sed -e "s/ Simulator$//"` | ||
if [ $scheme = default ]; then scheme=$(cat default); fi | ||
if [ "`ls -A | grep -i \\.xcworkspace\$`" ]; then filetype_parameter="workspace" && file_to_build="`ls -A | grep -i \\.xcworkspace\$`"; else filetype_parameter="project" && file_to_build="`ls -A | grep -i \\.xcodeproj\$`"; fi | ||
file_to_build=`echo $file_to_build | awk '{$1=$1;print}'` | ||
xcodebuild test-without-building -scheme "$scheme" -"$filetype_parameter" "$file_to_build" -destination "platform=$platform,name=$device" |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,30 @@ | ||
name: Xcode - Build and Analyze | ||
|
||
on: | ||
push: | ||
branches: [ "Dev" ] | ||
pull_request: | ||
branches: [ "Dev" ] | ||
|
||
jobs: | ||
build: | ||
name: Build and analyse default scheme using xcodebuild command | ||
runs-on: macos-latest | ||
|
||
steps: | ||
- name: Checkout | ||
uses: actions/checkout@v3 | ||
- name: Set Default Scheme | ||
run: | | ||
scheme_list=$(xcodebuild -list -json | tr -d "\n") | ||
default=$(echo $scheme_list | ruby -e "require 'json'; puts JSON.parse(STDIN.gets)['project']['targets'][0]") | ||
echo $default | cat >default | ||
echo Using default scheme: $default | ||
- name: Build | ||
env: | ||
scheme: ${{ 'default' }} | ||
run: | | ||
if [ $scheme = default ]; then scheme=$(cat default); fi | ||
if [ "`ls -A | grep -i \\.xcworkspace\$`" ]; then filetype_parameter="workspace" && file_to_build="`ls -A | grep -i \\.xcworkspace\$`"; else filetype_parameter="project" && file_to_build="`ls -A | grep -i \\.xcodeproj\$`"; fi | ||
file_to_build=`echo $file_to_build | awk '{$1=$1;print}'` | ||
xcodebuild clean build analyze -scheme "$scheme" -"$filetype_parameter" "$file_to_build" | xcpretty && exit ${PIPESTATUS[0]} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,23 @@ | ||
# This workflow will build a Swift project | ||
# For more information see: https://docs.github.com/en/actions/automating-builds-and-tests/building-and-testing-swift | ||
|
||
name: Swift | ||
|
||
on: | ||
push: | ||
branches: [ "Release" ] | ||
pull_request: | ||
branches: [ "Dev" ] | ||
|
||
jobs: | ||
build: | ||
|
||
runs-on: macos-latest | ||
|
||
steps: | ||
- uses: actions/checkout@v3 | ||
- name: Build | ||
run: swift build -v | ||
- name: Run tests | ||
run: tuist clean tuist fetch tuist generate --project-directory=PingPong/ | ||
xcodebuild clean test -workspace PingPong/PingPong.xcworkspace -scheme PingPong -destination 'platform=iOS Simulator,name=iPhone 14 Pro,OS=latest' |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1 +1 @@ | ||
3.33.3 | ||
3.35.5 |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
17 changes: 0 additions & 17 deletions
17
.../BeatCounter/ProjectDescriptionHelpers/DependencyPackage/Extension+TargetDependency.swift
This file was deleted.
Oops, something went wrong.
2 changes: 1 addition & 1 deletion
2
...tMaster/Plugins/BeatCounter/Package.swift → ...atMaster/Plugins/BeatMaster/Package.swift
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,4 +1,4 @@ | ||
// swift-tools-version: 5.4 | ||
// swift-tools-version: 5.8 | ||
|
||
import PackageDescription | ||
|
||
|
File renamed without changes.
18 changes: 18 additions & 0 deletions
18
...s/BeatMaster/ProjectDescriptionHelpers/DependencyPackage/Extension+TargetDependency.swift
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,18 @@ | ||
// | ||
// Extension+TargetDependency.swift | ||
// MyPlugin | ||
// | ||
// Created by 서원지 on 1/6/24. | ||
// | ||
|
||
import ProjectDescription | ||
|
||
public extension TargetDependency { | ||
enum SPM {} | ||
} | ||
|
||
public extension TargetDependency.SPM { | ||
static let Moya = TargetDependency.external(name: "Moya", condition: .none) | ||
static let CombineMoya = TargetDependency.external(name: "CombineMoya", condition: .none) | ||
static let ComposableArchitecture = TargetDependency.external(name: "ComposableArchitecture", condition: .none) | ||
} |
File renamed without changes.
Oops, something went wrong.