hint that checkout has to be done first #34
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey @Swatinem, thank you for this awesome project!
Disclaimer: I'm not very experienced either with GitHub actions or rust, so this might be an incorrect change -- feel free to ignore the PR if so.
As far as my experience with this action goes, it does not seem to do anything if the repo gets checked out after the cache setup. Placing the
actions/checkout
step before therust-cache
step seems to solve the problem though. SoIt might be a common practice in github actions community to always stick
actions/checkout
at the top of theyaml
file, but for someone less experienced like me it may seem intuitive to set up caches first, do everything else after - that's what I did, and had to pay for it with a couple of hours of debugging time.This change adds the checkout step to the readme example explicitly so people like myself who cluelessly copy-paste examples have less things to trip over :)