[SWA-146][FEAT] - Add Openocean support #1913
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
82aa3ec to
5919ef3
Compare
5919ef3 to
102e45a
Compare
✅ Deploy Preview for swapr ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
berteotti
reviewed
Mar 21, 2024
src/lib/eco-router/api.ts
Outdated
Comment on lines
310
to
318
| if (platform.name === RoutablePlatform.OPENOCEAN.name) { | ||
| return SwaprV3Trade.getQuote({ | ||
| quoteCurrency: currencyIn, | ||
| amount: currencyAmountOut, | ||
| maximumSlippage, | ||
| recipient: receiver, | ||
| tradeType: TradeType.EXACT_OUTPUT, | ||
| }) | ||
| } |
There was a problem hiding this comment.
This doesn't look right 😄
There was a problem hiding this comment.
Ahhh it was a test and you passed (?
Lol sorry, addressing it right now
Diogomartf
approved these changes
Mar 21, 2024
berteotti
approved these changes
Mar 21, 2024
|
Don't forget to merge this only after updating Swapr SDK version |
…pport that trade type
fa228cf to
73342dc
Compare
berteotti
approved these changes
Mar 22, 2024
ElRodrigote
added a commit
that referenced
this pull request
Mar 25, 2024
* feat(SWA-146): add Openocean support (#1913) * docs(SWA-138): update footer links to docs URLs --------- Co-authored-by: Berteotti <berteotti2@gmail.com>
ElRodrigote
added a commit
that referenced
this pull request
Mar 25, 2024
release: v1.0.0-beta.22.3 * feat(SWA-146): add Openocean support (#1913) * docs(SWA-138): update footer links to docs URLs
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: SWA-146
Description
Visual Evidence
How to test the changes