Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[SWA-46] Limit order refactoring #1839

Draft
wants to merge 37 commits into
base: develop
Choose a base branch
from
Draft

[SWA-46] Limit order refactoring #1839

wants to merge 37 commits into from

Conversation

wixzi
Copy link
Contributor

@wixzi wixzi commented Jun 15, 2023

Fixes: SWA-46

Description

Refactor limit order to accommodate new protocols and make it more maintainable code. This refactor aims to make the current CoW limit order work as it is in the new refactored code.

How to test the changes

CoW limit order should work without errors

Is there any risks or changes of failure to be considered

Medium: Limit order can cause issues.

@netlify
Copy link

netlify bot commented Jun 15, 2023 •
edited
Loading

✅ Deploy Preview for swapr ready!

Name Link
🔨 Latest commit 7fb1c68
🔍 Latest deploy log https://app.netlify.com/sites/swapr/deploys/64c7c31c2551bb0008336ef9
😎 Deploy Preview https://deploy-preview-1839--swapr.netlify.app/
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@wixzi wixzi changed the title Limit order refactoring [SWA-46] Limit order refactoring Jun 15, 2023
berteotti
berteotti reviewed Jun 16, 2023
View reviewed changes
Copy link
Collaborator

@berteotti berteotti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code is looking good and organised. Just left a comment :)

@wixzi wixzi force-pushed the feature/limit-order-optimization branch from b1dc737 to cad6291 Compare June 17, 2023 14:32
@github-actions github-actions bot temporarily deployed to feature-limit-order-optimization June 17, 2023 14:40 Destroyed
@github-actions github-actions bot temporarily deployed to feature-limit-order-optimization June 17, 2023 15:40 Destroyed
@github-actions github-actions bot temporarily deployed to feature-limit-order-optimization June 18, 2023 16:23 Destroyed
@github-actions github-actions bot temporarily deployed to feature-limit-order-optimization June 20, 2023 08:02 Destroyed
@github-actions github-actions bot temporarily deployed to feature-limit-order-optimization June 22, 2023 22:25 Destroyed
@wixzi wixzi force-pushed the feature/limit-order-optimization branch from 8767a3a to 0a08e7e Compare June 23, 2023 16:15
@github-actions github-actions bot temporarily deployed to feature-limit-order-optimization June 23, 2023 16:23 Destroyed
@github-actions github-actions bot temporarily deployed to feature-limit-order-optimization June 23, 2023 16:42 Destroyed
@wixzi wixzi force-pushed the feature/limit-order-optimization branch from 04912ba to 3557888 Compare June 23, 2023 16:45
@github-actions github-actions bot temporarily deployed to feature-limit-order-optimization June 23, 2023 16:55 Destroyed
@github-actions github-actions bot temporarily deployed to feature-limit-order-optimization June 24, 2023 13:48 Destroyed
@wixzi wixzi force-pushed the feature/limit-order-optimization branch from 197882c to 4cacee5 Compare July 21, 2023 19:54
@github-actions github-actions bot temporarily deployed to feature-limit-order-optimization July 21, 2023 20:04 Destroyed
@github-actions github-actions bot temporarily deployed to feature-limit-order-optimization July 25, 2023 17:47 Destroyed
@github-actions github-actions bot temporarily deployed to feature-limit-order-optimization July 26, 2023 15:05 Destroyed
@github-actions github-actions bot temporarily deployed to feature-limit-order-optimization July 26, 2023 15:31 Destroyed
@github-actions github-actions bot temporarily deployed to feature-limit-order-optimization July 26, 2023 18:06 Destroyed
@wixzi wixzi force-pushed the feature/limit-order-optimization branch from 55a45b7 to 22fb61c Compare July 28, 2023 15:14
@github-actions github-actions bot temporarily deployed to feature-limit-order-optimization July 28, 2023 15:20 Destroyed
@github-actions github-actions bot temporarily deployed to feature-limit-order-optimization July 28, 2023 17:39 Destroyed
@wixzi wixzi force-pushed the feature/limit-order-optimization branch from 7286c0e to 0345d92 Compare July 28, 2023 20:37
@github-actions github-actions bot temporarily deployed to feature-limit-order-optimization July 28, 2023 20:45 Destroyed
@github-actions github-actions bot temporarily deployed to feature-limit-order-optimization July 30, 2023 11:48 Destroyed
@github-actions github-actions bot temporarily deployed to feature-limit-order-optimization July 30, 2023 12:03 Destroyed
@github-actions github-actions bot temporarily deployed to feature-limit-order-optimization July 31, 2023 08:23 Destroyed
@berteotti berteotti force-pushed the develop branch 2 times, most recently from fb69230 to 0c5053c Compare August 26, 2023 10:19
@berteotti berteotti force-pushed the develop branch 2 times, most recently from ff47650 to b3b3815 Compare November 7, 2023 14:07
@berteotti berteotti force-pushed the develop branch 2 times, most recently from 91e4f23 to af06da1 Compare March 7, 2024 11:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@berteotti berteotti berteotti left review comments

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@wixzi @berteotti