Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[STK-218][FIX] - Stack orders should show the correct cow order status #142

Conversation

ElRodrigote
Copy link
Collaborator

Fixes: STK-218

Description

  • Update the way we handle how to visualize Cow order statuses.

Visual evidence

image

How to test the changes

PRE-CONDITIONS: You need to have existing stacks with executed orders in place to test this fix

  1. Pull this branch
  2. Run the project locally
  3. Go to Stackly dApp
  4. Connect your wallet
  5. Go to "Your Stacks", choose one of them, and click "View Details"
  6. When the Order Details modal opens up, the right-most column should have the correct order status

Copy link

vercel bot commented Dec 1, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
stackly-landing ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 12, 2023 2:15pm

Copy link

cloudflare-workers-and-pages bot commented Dec 11, 2023

Deploying with  Cloudflare Pages  Cloudflare Pages

Latest commit: d285f26
Status: ✅  Deploy successful!
Preview URL: https://b157b077.stackly-ui.pages.dev
Branch Preview URL: https://fix-stk-218-ui-should-show-i.stackly-ui.pages.dev

View logs

@ElRodrigote ElRodrigote force-pushed the fix/stk-218-ui-should-show-if-it-is-a-cow-order-has-expired branch from a0d5dbc to a968728 Compare December 11, 2023 18:44
Diogomartf
Diogomartf previously approved these changes Dec 11, 2023
@ElRodrigote ElRodrigote force-pushed the fix/stk-216-wrong-bought-token-price-on-orders-table branch from 94d7bb5 to 7f83643 Compare December 11, 2023 20:29
Base automatically changed from fix/stk-216-wrong-bought-token-price-on-orders-table to develop December 12, 2023 12:33
@ElRodrigote ElRodrigote dismissed Diogomartf’s stale review December 12, 2023 12:33

The base branch was changed.

@ElRodrigote ElRodrigote force-pushed the fix/stk-218-ui-should-show-if-it-is-a-cow-order-has-expired branch from a968728 to bfb1190 Compare December 12, 2023 12:54
berteotti
berteotti previously approved these changes Dec 12, 2023
Copy link
Collaborator

@berteotti berteotti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me after fixing what Diogo mentioned.

@ElRodrigote ElRodrigote merged commit 9a311d4 into develop Dec 12, 2023
@ElRodrigote ElRodrigote deleted the fix/stk-218-ui-should-show-if-it-is-a-cow-order-has-expired branch December 12, 2023 14:55
berteotti pushed a commit that referenced this pull request Dec 13, 2023
…142)

* fix(STK-218): fix the way we handle the order status visualization
ElRodrigote added a commit that referenced this pull request Dec 13, 2023
…142)

* fix(STK-218): fix the way we handle the order status visualization
ElRodrigote added a commit that referenced this pull request Dec 13, 2023
* refactor(STK-212) - Change FA implementation approach and add extra events (#137)
* feat(SWA-206) - Reset stackbox on network switch or stack creation (#135)
* chore: change from Erroring to Console when fathom site ID is missing to stop the app from crashing on dev (#138)
* styles(STK-188): Center dApp background image and update date pickers spacing (#140)
* feat(STK-209): Enable select network without a connected wallet (#139)
* fix(STK-216): Wrong AVG bought token price on executed orders table (#141)
* fix(STK-218): Stack orders should show the correct cow order status (#142)
berteotti pushed a commit that referenced this pull request Dec 14, 2023
…142)

* fix(STK-218): fix the way we handle the order status visualization
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants