-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[STK-218][FIX] - Stack orders should show the correct cow order status #142
Merged
ElRodrigote
merged 5 commits into
develop
from
fix/stk-218-ui-should-show-if-it-is-a-cow-order-has-expired
Dec 12, 2023
Merged
[STK-218][FIX] - Stack orders should show the correct cow order status #142
ElRodrigote
merged 5 commits into
develop
from
fix/stk-218-ui-should-show-if-it-is-a-cow-order-has-expired
Dec 12, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Diogomartf
reviewed
Dec 3, 2023
Diogomartf
reviewed
Dec 3, 2023
berteotti
reviewed
Dec 5, 2023
Deploying with
|
Latest commit: |
d285f26
|
Status: | ✅ Deploy successful! |
Preview URL: | https://b157b077.stackly-ui.pages.dev |
Branch Preview URL: | https://fix-stk-218-ui-should-show-i.stackly-ui.pages.dev |
a0d5dbc
to
a968728
Compare
Diogomartf
previously approved these changes
Dec 11, 2023
94d7bb5
to
7f83643
Compare
Base automatically changed from
fix/stk-216-wrong-bought-token-price-on-orders-table
to
develop
December 12, 2023 12:33
The base branch was changed.
…e a local enum instead
… outside a component
a968728
to
bfb1190
Compare
Diogomartf
reviewed
Dec 12, 2023
berteotti
previously approved these changes
Dec 12, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me after fixing what Diogo mentioned.
berteotti
approved these changes
Dec 12, 2023
berteotti
pushed a commit
that referenced
this pull request
Dec 13, 2023
…142) * fix(STK-218): fix the way we handle the order status visualization
ElRodrigote
added a commit
that referenced
this pull request
Dec 13, 2023
…142) * fix(STK-218): fix the way we handle the order status visualization
ElRodrigote
added a commit
that referenced
this pull request
Dec 13, 2023
* refactor(STK-212) - Change FA implementation approach and add extra events (#137) * feat(SWA-206) - Reset stackbox on network switch or stack creation (#135) * chore: change from Erroring to Console when fathom site ID is missing to stop the app from crashing on dev (#138) * styles(STK-188): Center dApp background image and update date pickers spacing (#140) * feat(STK-209): Enable select network without a connected wallet (#139) * fix(STK-216): Wrong AVG bought token price on executed orders table (#141) * fix(STK-218): Stack orders should show the correct cow order status (#142)
berteotti
pushed a commit
that referenced
this pull request
Dec 14, 2023
…142) * fix(STK-218): fix the way we handle the order status visualization
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: STK-218
Description
Visual evidence
How to test the changes
PRE-CONDITIONS: You need to have existing stacks with executed orders in place to test this fix