Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[SWA-203][PERF] - Improve RPC usage when using multicall #120

Merged
merged 5 commits into from
Oct 23, 2023
Merged

[SWA-203][PERF] - Improve RPC usage when using multicall #120

merged 5 commits into from
Oct 23, 2023

Conversation

ElRodrigote
Copy link
Collaborator

Fixes: SWA-203

Description

  • Wrap batch fetch balances inside a useCallback() hook
  • WAGMI configureChain batch flag added

How to test the changes

  1. Pull this branch
  2. Run the project locally
  3. Go to Swapr landing page
  4. Connect your wallet
  5. Try to open the token picker for any connected chain

@ElRodrigote ElRodrigote requested a review from berteotti October 19, 2023 14:55
@vercel
Copy link

vercel bot commented Oct 19, 2023 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
stackly-landing ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 23, 2023 2:02pm

@cloudflare-workers-and-pages
Copy link

cloudflare-workers-and-pages bot commented Oct 19, 2023 •
edited
Loading

Deploying with  Cloudflare Pages  Cloudflare Pages

Latest commit: 28ff3fe
Status: ✅  Deploy successful!
Preview URL: https://5727f171.stackly-ui.pages.dev
Branch Preview URL: https://perf-stk-203-improve-rpc-usa.stackly-ui.pages.dev

View logs

@ElRodrigote ElRodrigote force-pushed the perf/stk-203-improve-rpc-usage-when-using-multicall branch from 5d3dfc5 to 348cdd3 Compare October 20, 2023 16:47
berteotti
berteotti reviewed Oct 23, 2023
View reviewed changes
Copy link
Collaborator

@berteotti berteotti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job Rorry, just left a few comments

berteotti
berteotti approved these changes Oct 23, 2023
View reviewed changes
Copy link
Collaborator

@berteotti berteotti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job Rorry!

@ElRodrigote ElRodrigote merged commit 86758f2 into develop Oct 23, 2023
@ElRodrigote ElRodrigote deleted the perf/stk-203-improve-rpc-usage-when-using-multicall branch October 23, 2023 18:59
berteotti pushed a commit that referenced this pull request Nov 9, 2023
@ElRodrigote @berteotti
perf(STK-203): Improve RPC usage when using multicall (#120)
3257c5e 
* perf(STK-203): use a provider and multicall interface instead WAGMI multicall for user balances
berteotti pushed a commit that referenced this pull request Nov 9, 2023
@ElRodrigote @berteotti
perf(STK-203): Improve RPC usage when using multicall (#120)
f6c5440 
* perf(STK-203): use a provider and multicall interface instead WAGMI multicall for user balances
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Diogomartf Diogomartf Diogomartf approved these changes

@berteotti berteotti berteotti approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ElRodrigote @Diogomartf @berteotti