Crash when fetching video information

[shadone]

What happened?

The crash occurs on YouTubePlayerWebView+Evaluate.swift:147 on line .store(in: &self.cancellables)

When it crashes, the execution happens in background thread, I believe the issue is concurrent access to shared variable cancellables.

I am not sure that's the best solution, but adding @MainActor attribute to getInformation() solves the problem for me

    #if compiler(>=5.5) && canImport(_Concurrency)
    /// Retrieve the YouTubePlayer Information
    @MainActor // <<<< this solves the problem for me.
    func getInformation() async throws -> Information {
        try await withCheckedThrowingContinuation { continuation in
            self.getInformation(completion: continuation.resume)
        }
    }
    #endif

What are the steps to reproduce?

Here is a piece of code showing how I use YouTubePLayerView

struct VideoView: View {
    let player: YouTubePlayer

    @State private var title: String?
    @State private var duration: Double?

    init(youtubeUrl: URL) {
        var config = YouTubePlayer.Configuration()
        config.fullscreenMode = .system
        config.useModestBranding = true
        config.playInline = false

        player = YouTubePlayer(source: .url(youtubeUrl.absoluteString), configuration: config)
    }

    var body: some View {
        VStack {
            YouTubePlayerView(player)
                .frame(height: 192)
            if let title {
                Text(title)
                    .multilineTextAlignment(.leading)
                    .padding(EdgeInsets(top: 32, leading: 16, bottom: 0, trailing: 16))
                    .frame(maxWidth: .infinity, alignment: .leading)
            }
            Button("\(duration ?? 0)", systemImage: "play.fill") { }
                .buttonStyle(.play)
                .padding(EdgeInsets(top: 0, leading: 16, bottom: 16, trailing: 16))
                .frame(maxWidth: .infinity, alignment: .leading)
        }
        .task { @MainActor in
            async let info = player.getInformation()
            async let metadata = player.getPlaybackMetadata()
            title = try? await metadata.title
            duration = try? await info.duration
        }
    }

What is the expected behavior?

Not crash would be great :)

[SvenTiigi]

Hi @shadone,

Thanks for your detailed bug report 👍

A fix is now available on the develop branch.
Please let me know if this resolves your issue.

[shadone]

I believe that solves it! I cannot reproduce the crash any more. Thanks for such a quick reply!

[SvenTiigi]

The fix is now available with the latest release 1.6.0