Skip to content
This repository has been archived by the owner on Dec 18, 2023. It is now read-only.

Added tests for additional db operations #67

Merged
merged 6 commits into from
Sep 29, 2022

Conversation

Du-z
Copy link
Collaborator

@Du-z Du-z commented Sep 28, 2022

Struggled to get RPC Modify to work, it is currently failing with error code -32602 (Invalid params).

I'm not to sure if I am using Modify correctly though.

@Du-z
Copy link
Collaborator Author

Du-z commented Sep 28, 2022

Remaining list of tests now includes.

  • Multiple result set handing
  • DB Error Responses
  • Multithreaded testing

@ProphetLamb
Copy link
Collaborator

Thanks! Ill have a look at the failing tests later on.

@ProphetLamb
Copy link
Collaborator

Please note that modify uses JSON Patch syntax

@ProphetLamb
Copy link
Collaborator

Apparently there was a breaking change to PATCH vs CHANGE for the REST endpoint. Fixed it

Copy link
Collaborator

@ProphetLamb ProphetLamb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good! Thanks for the testcases!

@ProphetLamb ProphetLamb merged commit 96402d8 into master Sep 29, 2022
@ProphetLamb ProphetLamb deleted the test_other_db_operations branch September 29, 2022 11:50
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants