-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: support to hostname includes dots #21
feat: support to hostname includes dots #21
Conversation
https://github.com/prometheus/statsd_exporter The documentation for the statsd_exporter mentions that regex parsing can be slow. I would like to test the speed of the exporter with this change and the resource usage before merging. If you have time feel free to do a comparison. I will mostly likely get to it on the weekend. @yuta1024 |
Thank you for you reply! I add It seems to be no significant peformance degration. However I don't know what happen until time passed. So I will wait about 1 day and check again. I hope this will be useful to you.
Machine specs(Docker on Ubuntu 22.04.2 LTS on Proxmox VE):
|
@yuta1024 Could you rebase your branch real quick then I get a docker image for my testing as well. But your results look promising |
ddaaaf1
to
efb2686
Compare
@Supporterino OK, I rebased branch. I checked processing time again for one push. The result is 0.137 secs. |
I also did my fair checking and the performance hit isn't notable to I am going to merge it. @yuta1024 thank you for your patience |
Thank you! |
cpu_idlestate
,cpu_usage
andzfs_pool
accept hostname that includes dots. However, other metrics does not accept it. Therefore, this PR fix all patterns to use regex same likecpu_idlestate
etc.Before
After