fix: HTTP Send parameter key issues #167
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fixes unwanted _1 being appended to keys that are not duplicates; deletes parameter meant to be deleted, keeping parameter count accurate; prevents overriding an existing parameter when adding a new one
|
Kudos, SonarCloud Quality Gate passed!
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes three issues around
EditTimelineObjHTTPSendAny_1was appended to keys that were not duplicates, when the Key input was focused and un-focused without making a changeundefined, making the parameter count and numbering inaccurateNote: using deepmerge-ts with customized record merging was the cleanest thing I could come up with. Alternatively we could just stringify and parse those objects to have
undefinedremoved, or avoid passingundefinedbetween renderer and main process, and instead use some other way of marking properties to delete.