Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update otelcol core to v0.96.0 #1478

Merged
merged 3 commits into from
Mar 7, 2024

Conversation

kasia-kujawa
Copy link
Contributor

@kasia-kujawa kasia-kujawa commented Mar 6, 2024

changes which impact update:

@kasia-kujawa kasia-kujawa force-pushed the kkujawa-update-ot-core_0.96.0 branch 2 times, most recently from e8ac005 to e9e81ae Compare March 6, 2024 13:12
@kasia-kujawa kasia-kujawa marked this pull request as ready for review March 6, 2024 13:21
@kasia-kujawa kasia-kujawa requested a review from a team as a code owner March 6, 2024 13:21
Copy link

@swiatekm swiatekm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You have some lint errors in the builder generated code, otherwise LGTM.

@kasia-kujawa
Copy link
Contributor Author

One more deprecation left reported by golangci-lint:

		params.ConfigProvider, err = NewConfigProvider(locations)
		^
Error: configprovider.go:83:3: SA1019: params.ConfigProvider is deprecated: [v0.95.0] Use ConfigProviderSettings instead. ConfigProvider provides the service configuration. If the provider watches for configuration change, collector may reload the new configuration upon changes. (staticcheck)
		params.ConfigProvider, err = otelcol.NewConfigProvider(settings)
		^
make[3]: *** [Makefile:18: lint] Error 1

@kasia-kujawa kasia-kujawa force-pushed the kkujawa-update-ot-core_0.96.0 branch from c978dd4 to 5456880 Compare March 7, 2024 12:11
changes which impacts update:
- httpforwarder: Remove extension named httpforwarder, use httpforwarderextension instead
  ref: open-telemetry/opentelemetry-collector-contrib#24171
- spanmetricsprocessor: Remove spanmetrics processor
  ref: open-telemetry/opentelemetry-collector-contrib#29567
- confighttp: Remove deprecated HTTPClientSettings, NewDefaultHTTPClientSettings, and CORSSettings.
  ref: open-telemetry/opentelemetry-collector#9625
- ConfigProvider is deprecated, use ConfigProviderSettings instead
  ref: open-telemetry/opentelemetry-collector#9228
@kasia-kujawa kasia-kujawa force-pushed the kkujawa-update-ot-core_0.96.0 branch from 5456880 to 3c397ac Compare March 7, 2024 12:21
@aboguszewski-sumo
Copy link
Contributor

httpforwarder: Remove extension named httpforwarder, use httpforwarderextension instead ref: open-telemetry/opentelemetry-collector-contrib#24171

are there any config changes?

@kasia-kujawa
Copy link
Contributor Author

kasia-kujawa commented Mar 7, 2024

httpforwarder: Remove extension named httpforwarder, use httpforwarderextension instead ref: open-telemetry/opentelemetry-collector-contrib#24171

are there any config changes?

There aren't any changes in the configuration.

configuration for httpforwarder

## Configuration

The following settings are required:

- `egress`: HTTP config settings to use for forwarding requests.
  - `endpoint` (no default): The target to which requests should be forwarded to.

The following settings can be optionally configured:

- `ingress`: HTTP config settings for HTTP server listening to requests.
  - `endpoint` (default = `0.0.0.0:6060`): The host to which requests should be forwarded to.
- `egress`: HTTP config settings to use for forwarding requests.
  - `headers` (default = `nil`): Additional headers to be added to all requests passing through the extension.
  - `timeout` (default = `10s`): How long to wait for each request to complete.

### Example

```yaml
  http_forwarder:
    ingress:
      endpoint: localhost:7070
    egress:
      endpoint: http://target/
      headers:
        otel_http_forwarder: dev
      timeout: 5s

configuration for httpforwarderextension

## Configuration

The following settings are required:

- `egress`: HTTP config settings to use for forwarding requests.
  - `endpoint` (no default): The target to which requests should be forwarded to.

The following settings can be optionally configured:

- `ingress`: HTTP config settings for HTTP server listening to requests.
  - `endpoint` (default = `0.0.0.0:6060`): The host to which requests should be forwarded to.
- `egress`: HTTP config settings to use for forwarding requests.
  - `headers` (default = `nil`): Additional headers to be added to all requests passing through the extension.
  - `timeout` (default = `10s`): How long to wait for each request to complete.

### Example

```yaml
  http_forwarder:
    ingress:
      endpoint: localhost:7070
    egress:
      endpoint: http://target/
      headers:
        otel_http_forwarder: dev
      timeout: 5s

github.com/SumoLogic/sumologic-otel-collector/pkg/exporter/sumologicexporter v0.93.0-sumo-0
github.com/SumoLogic/sumologic-otel-collector/pkg/extension/sumologicextension v0.91.0-sumo-0
github.com/SumoLogic/sumologic-otel-collector/pkg/exporter/sumologicexporter v0.0.0-00010101000000-000000000000
github.com/SumoLogic/sumologic-otel-collector/pkg/extension/sumologicextension v0.77.0-sumo-0
Copy link
Contributor

@andrzej-stencel andrzej-stencel Mar 7, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

v0.77.0-sumo0? 🤔

This is replaced anyway, but I wonder if this is the version that appears in the otelcol logs later.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I intentionally set v0.0.0-00010101000000-000000000000 for sumologicexporter because without this change update wasn't possible
but I absolutely don't know why sumologicextension has v0.77.0-sumo-0 - I'll change this also to v0.0.0-00010101000000-000000000000

@kasia-kujawa kasia-kujawa merged commit 560e077 into main Mar 7, 2024
30 checks passed
@kasia-kujawa kasia-kujawa deleted the kkujawa-update-ot-core_0.96.0 branch March 7, 2024 14:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants