-
Notifications
You must be signed in to change notification settings - Fork 39
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: update otelcol core to v0.96.0 #1478
Conversation
e8ac005
to
e9e81ae
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You have some lint errors in the builder generated code, otherwise LGTM.
One more deprecation left reported by golangci-lint:
|
c978dd4
to
5456880
Compare
changes which impacts update: - httpforwarder: Remove extension named httpforwarder, use httpforwarderextension instead ref: open-telemetry/opentelemetry-collector-contrib#24171 - spanmetricsprocessor: Remove spanmetrics processor ref: open-telemetry/opentelemetry-collector-contrib#29567 - confighttp: Remove deprecated HTTPClientSettings, NewDefaultHTTPClientSettings, and CORSSettings. ref: open-telemetry/opentelemetry-collector#9625 - ConfigProvider is deprecated, use ConfigProviderSettings instead ref: open-telemetry/opentelemetry-collector#9228
5456880
to
3c397ac
Compare
are there any config changes? |
There aren't any changes in the configuration. configuration for
configuration for
|
pkg/extension/opampextension/go.mod
Outdated
github.com/SumoLogic/sumologic-otel-collector/pkg/exporter/sumologicexporter v0.93.0-sumo-0 | ||
github.com/SumoLogic/sumologic-otel-collector/pkg/extension/sumologicextension v0.91.0-sumo-0 | ||
github.com/SumoLogic/sumologic-otel-collector/pkg/exporter/sumologicexporter v0.0.0-00010101000000-000000000000 | ||
github.com/SumoLogic/sumologic-otel-collector/pkg/extension/sumologicextension v0.77.0-sumo-0 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
v0.77.0-sumo0
? 🤔
This is replace
d anyway, but I wonder if this is the version that appears in the otelcol logs later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I intentionally set v0.0.0-00010101000000-000000000000
for sumologicexporter because without this change update wasn't possible
but I absolutely don't know why sumologicextension
has v0.77.0-sumo-0
- I'll change this also to v0.0.0-00010101000000-000000000000
changes which impact update: