Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

data handling for form and topic pages added #32

Merged
merged 3 commits into from
Jun 5, 2024
Merged

data handling for form and topic pages added #32

merged 3 commits into from
Jun 5, 2024

Conversation

jtmst
Copy link
Contributor

@jtmst jtmst commented Jun 4, 2024 •
edited
Loading

This PR addresses the following issues:
#20
#11

Changes:

  • Modifies form component so that it can be reused for topic sections and all forms pages
  • Adjusts queries to match
  • Adds support for markdown from api (new packages added for that)
  • Makes topic pages styling work mobile/desktop
  • Adjusts topic config to always use lower case for consistancy

Note - Extra loc and file changes because of new packages for markdown support.

QA steps:

  • visit /forms and observe the layout there
  • visit /ma/housing and observe the layout there matches

Screenshots:
image
image
image
image

nonprofittechy
nonprofittechy approved these changes Jun 4, 2024
View reviewed changes
Copy link
Member

@nonprofittechy nonprofittechy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jtmst jtmst merged commit fa704e0 into main Jun 5, 2024
2 checks passed
@samglover samglover deleted the 20-data-for-pages branch September 20, 2024 03:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nonprofittechy nonprofittechy nonprofittechy approved these changes

@johnphamvan johnphamvan Awaiting requested review from johnphamvan

@codestronger codestronger Awaiting requested review from codestronger

@KindBill KindBill Awaiting requested review from KindBill

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jtmst @nonprofittechy