-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
18 new jurisdictions via config #30
Conversation
src/config/formSources.config.js
Outdated
path: 'ma', | ||
}, | ||
{ | ||
key: 'greaterBostonLegalService', | ||
url: 'https://interviews.gbls.org', | ||
name: 'Greater Boston Legal Services', | ||
path: 'gb', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just wanted to double-check: it's possible for two servers to share the same path, right? Edit: and conversely, for one server to have individual interviews that go to different paths? See note below about the jurisdiction
attribute.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What do you envision determining which servers are associated with a given path, should that be a seperate config where each path has an array of servers they pull from?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's important now that multiple servers can point to the same path, since we're thinking of the path as relating to the jurisdiction. The two example servers we're pulling from here are both in Massachusetts and would be syndicated to the same path.
In the future, we'd like to consider hosting a small number of forms for outside jurisdictions. For example: if we help Minnesota build 3 forms, it would be nice if those could go to courtformsonline.org/mn even if they're hosted on apps.suffolklitlab.org. That would be something we'd just do for relatively small numbers of forms.
I can also see multiple servers around the country having US-national level forms that should all go to the same path, /us/.
To get that outcome, I trust your judgment on the proper implementation.
Here's one path that might meet all of our needs for flexibility:
- Each path is associated with a jurisdiction code or codes, and will show all forms matching that jurisdiction's codes
- Each interview can specify the jurisdiction code or codes in its metadata (the JSON endpoint)
- Each server has a default jurisdiction code, which will be used if the interview doesn't specify one
If this feature is getting too complex, happy to talk it through more and figure out the right tradeoffs.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Gotcha, thanks for the clarification
src/app/page.tsx
Outdated
{filteredTopics.length > 9 && <ShowAllToggle />} | ||
</div> | ||
</section> | ||
<TopicsSection jurisdiction={'ma'} /> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
How does jurisdiction correspond to the jurisdiction in the JSON endpoint, which uses the SALI/LMSS location descriptors? Are we planning to say all interviews from a server go to the same path, or can we categorize based on the jurisdiction in the endpoint, with perhaps a default path for each server since not all interviews will have a jurisdiction in the metadata?
E.g., US states look like:
NAM-US-US+MA
And Berlin looks like:
EUR-DE-DE+BE
(You can browse interactively here: https://webprotege.stanford.edu/#login).
Just want to check for consistency here--if this is jurisdiction, maybe we want to match the two formats, and map the jurisdiction code to a path. if it's just path, using the same variable name perhaps?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I may just be using the term jurisdiction wrong. In this case I'm using jurisdiction to denote which path/server we are looking at. Rather than jurisdiction, what term should i use for the path (previously subdomain) ie /ma/ or /pa/. I'm assuming they wont always be by state or I would use that.
I do have this set now so that path to server is 1 to 1, but I see now that we need to allow multiple servers' data within a path. I will adjust and get those changes up
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think "path" is fine. Just think it will be helpful, if the path isn't identical to the jurisdiction code, to not use the word "jurisdiction"
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I like these changes--looking good! Just two notes: consistency of the meaning of "jurisdiction" and double-checking that we can combine multiple servers into one "path", made inline.
I've modified the config that that we can assign multiple servers to a path. I included I've also added in the necessary data to track the source server for an interview so that the link path aligns with its source. Also changed misusage of 'jurisdiction' to 'path' for clarity |
#18
Adds ability to add jurisdictions by modifying the formsources.config file.
Changes:
/ma
and/ma/housing
Testing
Build output log:
Greater boston cards at /gb:
Placeholder component for topics at new route:
Note: Also some changes to images in an effort to get them working on Pages. I dont have a way to test pages deployment locally so there may be some trial and error figuring out what the issue is there