Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: separate download function from execute task #883

Merged

Conversation

guilhem-barthes
Copy link
Contributor

@guilhem-barthes guilhem-barthes commented Apr 10, 2024

Description

Add a new task profiling step, download_function when the function owner is different from the worker and that the worker needs to download the function from the builder

Fixes FL-1520

Companion PR

How has this been tested?

Checklist

  • changelog was updated with notable changes
  • documentation was updated

@guilhem-barthes guilhem-barthes requested a review from a team as a code owner April 10, 2024 05:38
Copy link

linear bot commented Apr 10, 2024

@guilhem-barthes
Copy link
Contributor Author

/e2e --tests frontend,substrafl

@Owlfred
Copy link

Owlfred commented Apr 10, 2024

End to end tests: ✔️ SUCCESS

Aw yeah!

Signed-off-by: Guilhem Barthés <guilhem.barthes@owkin.com>
Signed-off-by: Guilhem Barthés <guilhem.barthes@owkin.com>
Signed-off-by: Guilhem Barthés <guilhem.barthes@owkin.com>
Signed-off-by: Guilhem Barthés <guilhem.barthes@owkin.com>
Signed-off-by: Guilhem Barthés <guilhem.barthes@owkin.com>
Signed-off-by: Guilhem Barthés <guilhem.barthes@owkin.com>
@guilhem-barthes guilhem-barthes force-pushed the feat/separate-download_function-from-execute-task branch from 341280a to d6b9e4d Compare April 11, 2024 09:51
@guilhem-barthes guilhem-barthes merged commit 84ba575 into main Apr 11, 2024
7 checks passed
@guilhem-barthes guilhem-barthes deleted the feat/separate-download_function-from-execute-task branch April 11, 2024 09:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants