Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix detection of << end. #24

Merged
merged 1 commit into from
May 8, 2017
Merged

Conversation

Kentzo
Copy link
Contributor

@Kentzo Kentzo commented May 8, 2017

Before:

before

After:

after

@alexlouden
Copy link
Collaborator

Hey @Kentzo thanks for this! Resolves #23

@alexlouden alexlouden merged commit 0594ba9 into SublimeText:master May 8, 2017
@Kentzo
Copy link
Contributor Author

Kentzo commented May 8, 2017

@alexlouden I'll be working with TF for some time and would love to address what I can.
If you have time, please add issues so I could work through them.

@alexlouden
Copy link
Collaborator

alexlouden commented May 8, 2017

Oh awesome, that'd be great. I've been hoping to build in more TF/Consul syntax and make it a bit more user friendly, but I can't think of anything major at the moment. I've recently added TF keywords, and I was thinking about highlighting invalid syntax (missing closing braces, etc).

Do you use bash scripts in your heredoc - I think it's possible to fall back to the bash syntax language within e.g. <<SHELL?

Keen to hear any suggestions you have (or anyone else reading this has) too!

@Kentzo
Copy link
Contributor Author

Kentzo commented May 9, 2017

@alexlouden I'm not aware of any consistent usage of <<SHELL, and google doesn't show any results. In other hand I seldom use <<.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants