add ability to pass in callback function for link clicks #8
+39
−19
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for the pull request! I'll look through it a little later today. |
|
@loitran Sorry this review is taking a bit longer than usual due to #9. I will be pushing the fix for #9 in the next couple days. Since it is a major refactor of the entire library, you will probably have to merge the changes and rewrite this feature with the new code. Since this may be a bit of an inconvenience, just let me know and I'll be happy to write it myself. But I'd much rather you get the credit for this pull request. |
|
@Sub6Resources I don't mind reimplementing the feature. |
|
@loitran The new version has been pushed. |
|
@loitran any progress on this? |
|
@Sub6Resources I created a new pull request. This can be deleted. |
Closed
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows developer to open links in something like flutter_webview_plugin.