Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change rendering <li> #36

Closed
wants to merge 1 commit into from
Closed

Conversation

Kapranov98
Copy link

The problem with the transfer of rows in the tag

  • fixed with Row and Expanded. In my opinion, this option looks even more beautiful.

  • @Sub6Resources
    Copy link
    Owner

    Thanks for the pull request. I'll work on reviewing this as I have time.

    @Sub6Resources Sub6Resources self-requested a review November 6, 2018 23:08
    @Sub6Resources Sub6Resources self-assigned this Nov 6, 2018
    @Sub6Resources Sub6Resources added the bugfix Fixes a bug in the package label Nov 6, 2018
    @Kapranov98
    Copy link
    Author

    I think this fix is no longer relevant. The jeffmikels solution looks more complete.
    #37

    @Sub6Resources
    Copy link
    Owner

    #37 creates a separate optional renderer, but the default renderer will still have the issue. I will keep this open and likely merge this fix after merging #37.

    @Sub6Resources
    Copy link
    Owner

    I'm working on adding fixes from the new parser from the jeffmikels solution in #37 to the old parser. I will probably use his fix rather than this one. Thank you for the pull request, though!

    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Labels
    bugfix Fixes a bug in the package
    Projects
    None yet
    Development

    Successfully merging this pull request may close these issues.

    2 participants