Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Add WrapperExtension helper #1264

Merged
merged 4 commits into from
May 15, 2023
Merged

feat: Add WrapperExtension helper #1264

merged 4 commits into from
May 15, 2023

Conversation

Sub6Resources
Copy link
Owner

@Sub6Resources Sub6Resources commented May 15, 2023 •
edited
Loading

Fixes #1262

@codecov
Copy link

codecov bot commented May 15, 2023 •
edited
Loading

Codecov Report

Patch coverage: 94.64% and project coverage change: +0.56 🎉

Comparison is base (8ac444b) 57.16% compared to head (e467e3f) 57.73%.

Additional details and impacted files 
@@            Coverage Diff             @@
##           master    #1264      +/-   ##
==========================================
+ Coverage   57.16%   57.73%   +0.56%     
==========================================
  Files          36       37       +1     
  Lines        2610     2645      +35     
==========================================
+ Hits         1492     1527      +35     
  Misses       1118     1118
Impacted Files Coverage Δ
lib/src/builtins/details_element_builtin.dart 11.11% <0.00%> (ø)
lib/src/builtins/image_builtin.dart 60.39% <ø> (ø)
lib/src/builtins/ruby_builtin.dart 92.06% <ø> (ø)
lib/src/builtins/text_builtin.dart 95.83% <ø> (ø)
lib/src/extension/helpers/image_extension.dart 0.00% <0.00%> (ø)
lib/src/extension/helpers/image_tap_extension.dart 0.00% <0.00%> (ø)
lib/src/extension/helpers/matcher_extension.dart 53.84% <ø> (ø)
lib/src/extension/helpers/tag_extension.dart 58.33% <ø> (ø)
lib/src/extension/html_extension.dart 81.25% <ø> (ø)
...ackages/flutter_html_svg/lib/flutter_html_svg.dart 87.39% <ø> (ø)
... and 5 more

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@Sub6Resources Sub6Resources mentioned this pull request May 15, 2023
Closed
@Sembauke
Copy link

Sembauke commented May 15, 2023 •
edited
Loading

It might be hard for the user to know what the difference is between a TagExtension and a WrapperExtension class. Because they basically do the same thing?

@Sub6Resources
Copy link
Owner Author

Sub6Resources commented May 15, 2023 •
edited
Loading

Fair. I can add some more documentation. Essentially the TagExtension is for providing a custom widget in place of a tag. For example, rendering all <flutter> tags as a FlutterLogo widget. The WrapperExtension is for wrapping any instance of a tag inside of another widget, while still rendering the tag using the built-in tag support or other extensions.

Would naming like WrapTagExtension be clearer?

@Sembauke
Copy link

Yes, I think WrapTagExtension would make things a bit more clear. But I also think there should be some good documentation on what the differences are. Keep them close in the example too.

@Sub6Resources
Copy link
Owner Author

Sub6Resources commented May 15, 2023 •
edited
Loading

I just renamed the Extension and added a bit more documentation.

Some of the documentation is yet to come in the form of the wiki: https://github.com/Sub6Resources/flutter_html/wiki/How-To-Use-Extensions. Sorry my documentation isn't super flushed out yet!

@Sembauke
Copy link

No worries, I am only pointing these things out cause I am trying to help and make it better!

@Sub6Resources Sub6Resources merged commit 2ffa1dd into master May 15, 2023
@Sub6Resources Sub6Resources deleted the feat/wrapper-extension branch May 15, 2023 16:58
Luca-CZ added a commit to CZ-App/flutter_html_lite that referenced this pull request Nov 11, 2024
@Luca-CZ
Merge tag 'flutter_html-v3.0.0-beta.2' into feature/update_package_ve…
afae63c 
…rsion

 - **FIX**: start list items on a new line ([Sub6Resources#1281](Sub6Resources#1281)). ([496d1aa](Sub6Resources@496d1aa))
 - **FIX**: Add "display: Display.block" to table ([Sub6Resources#1278](Sub6Resources#1278)). ([6350f02](Sub6Resources@6350f02))
 - **FIX**: improve API for ExtensionContext and export marker.dart ([Sub6Resources#1273](Sub6Resources#1273)). ([27e33a9](Sub6Resources@27e33a9))
 - **FIX**: Cleaned up whitespace processing and added whitespace tests ([Sub6Resources#1267](Sub6Resources#1267)). ([cc00406](Sub6Resources@cc00406))
 - **FIX**: a tag should not style as link if href is not provided ([Sub6Resources#1265](Sub6Resources#1265)). ([d7247cb](Sub6Resources@d7247cb))
 - **FEAT**: Update CssBoxWidget to handle rtl marker boxes ([Sub6Resources#1270](Sub6Resources#1270)). ([d709199](Sub6Resources@d709199))
 - **FEAT**: support vertical-align in inline styles ([Sub6Resources#1266](Sub6Resources#1266)). ([fe896de](Sub6Resources@fe896de))
 - **FEAT**: Add WrapperExtension helper ([Sub6Resources#1264](Sub6Resources#1264)). ([2ffa1dd](Sub6Resources@2ffa1dd))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[QUESTION] wrap table is scrollview flutter 3.0.0-beta.1
2 participants
@Sub6Resources @Sembauke