tests: Address incorrect built-in function check #1129
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Charlie Egan <charlie@styra.com>
charlieegan3
commented
Sep 23, 2024
| bis := rego.GetBuiltins() | ||
|
|
||
| // Search for a builtin we know is only in the EOPA capabilities. | ||
| if _, ok := bis["startswith"]; ok { | ||
| if _, ok := bis["neo4j.query"]; ok { |
There was a problem hiding this comment.
This is the main update.
charlieegan3
commented
Sep 23, 2024
| timeout = time.NewTimer(defaultTimeout) | ||
| defer timeout.Stop() | ||
|
|
||
| ticker := time.NewTicker(100 * time.Millisecond) |
There was a problem hiding this comment.
Using a ticker is just for consistency with the below check
anderseknert
approved these changes
Sep 23, 2024
|
Hmm, TestGetInlayHintsAstCall... I hadn't seen that in a while... Will merge for now and see about this one tomorrow. |
|
Haven't heard that name in years! |
charlieegan3
added a commit
to charlieegan3/regal
that referenced
this pull request
Sep 24, 2024
Built ins must now be provided by the caller. We have been having a number of issues where the shared list of builtins was required to be in a different state in different tests. Related StyraInc#1101 StyraInc#1102 StyraInc#1112 StyraInc#1121 StyraInc#1129 Signed-off-by: Charlie Egan <charlie@styra.com>
charlieegan3
added a commit
to charlieegan3/regal
that referenced
this pull request
Sep 24, 2024
Built ins must now be provided by the caller. We have been having a number of issues where the shared list of builtins was required to be in a different state in different tests. Related StyraInc#1101 StyraInc#1102 StyraInc#1112 StyraInc#1121 StyraInc#1129 Signed-off-by: Charlie Egan <charlie@styra.com>
charlieegan3
added a commit
to charlieegan3/regal
that referenced
this pull request
Sep 24, 2024
Built ins must now be provided by the caller. We have been having a number of issues where the shared list of builtins was required to be in a different state in different tests. Related StyraInc#1101 StyraInc#1102 StyraInc#1112 StyraInc#1121 StyraInc#1129 Signed-off-by: Charlie Egan <charlie@styra.com>
charlieegan3
added a commit
to charlieegan3/regal
that referenced
this pull request
Sep 24, 2024
Built ins must now be provided by the caller. We have been having a number of issues where the shared list of builtins was required to be in a different state in different tests. Related StyraInc#1101 StyraInc#1102 StyraInc#1112 StyraInc#1121 StyraInc#1129 Signed-off-by: Charlie Egan <charlie@styra.com>
charlieegan3
added a commit
to charlieegan3/regal
that referenced
this pull request
Sep 24, 2024
Built ins must now be provided by the caller. We have been having a number of issues where the shared list of builtins was required to be in a different state in different tests. Related StyraInc#1101 StyraInc#1102 StyraInc#1112 StyraInc#1121 StyraInc#1129 Signed-off-by: Charlie Egan <charlie@styra.com>
srenatus
pushed a commit
to srenatus/regal
that referenced
this pull request
Oct 1, 2024
Signed-off-by: Charlie Egan <charlie@styra.com>
srenatus
pushed a commit
to srenatus/regal
that referenced
this pull request
Oct 1, 2024
Built ins must now be provided by the caller. We have been having a number of issues where the shared list of builtins was required to be in a different state in different tests. Related StyraInc#1101 StyraInc#1102 StyraInc#1112 StyraInc#1121 StyraInc#1129 Signed-off-by: Charlie Egan <charlie@styra.com>
charlieegan3
added a commit
to charlieegan3/regal
that referenced
this pull request
Jan 6, 2025
Signed-off-by: Charlie Egan <charlie@styra.com>
charlieegan3
added a commit
to charlieegan3/regal
that referenced
this pull request
Jan 6, 2025
Built ins must now be provided by the caller. We have been having a number of issues where the shared list of builtins was required to be in a different state in different tests. Related StyraInc#1101 StyraInc#1102 StyraInc#1112 StyraInc#1121 StyraInc#1129 Signed-off-by: Charlie Egan <charlie@styra.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After seeing https://github.com/StyraInc/regal/actions/runs/10996729351/job/30530568473, I had another look at this one. I spotted the built-in is incorrect here, I think? Not thinking this is the main fix, but this should log to make it clear when we see the next failure.