fixer: add --on-conflict flag to support renaming #1127
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This PR adds a new flag to the fix command, `--on-conflict`. This flag can be used to specify the behavior of the fix command when a file's new name conflicts with an existing file or another file's fixed name. Setting --on-conflict to "rename" will cause the fix command to rename the file to a different name at the target location. The new name will be generated by appending a number to the end of the file name. Signed-off-by: Charlie Egan <charlie@styra.com>
anderseknert
approved these changes
Sep 23, 2024
| - directory-package-mismatch | ||
| quz/foo.rego -> foo/foo_1.rego: | ||
| - directory-package-mismatch | ||
| quz/foo_test.rego -> foo/foo_1_test.rego: |
srenatus
pushed a commit
to srenatus/regal
that referenced
this pull request
Oct 1, 2024
This PR adds a new flag to the fix command, `--on-conflict`. This flag can be used to specify the behavior of the fix command when a file's new name conflicts with an existing file or another file's fixed name. Setting --on-conflict to "rename" will cause the fix command to rename the file to a different name at the target location. The new name will be generated by appending a number to the end of the file name. Signed-off-by: Charlie Egan <charlie@styra.com>
charlieegan3
added a commit
to charlieegan3/regal
that referenced
this pull request
Jan 6, 2025
This PR adds a new flag to the fix command, `--on-conflict`. This flag can be used to specify the behavior of the fix command when a file's new name conflicts with an existing file or another file's fixed name. Setting --on-conflict to "rename" will cause the fix command to rename the file to a different name at the target location. The new name will be generated by appending a number to the end of the file name. Signed-off-by: Charlie Egan <charlie@styra.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a new flag to the fix command,
--on-conflict. This flag can be used to specify the behavior of the fix command when a file's new name conflicts with an existing file or another file's fixed name.Setting --on-conflict to "rename" will cause the fix command to rename the file to a different name at the target location. The new name will be generated by appending a number to the end of the file name.