Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

phase 2 - added trade config #995

Merged
merged 15 commits into from
Nov 29, 2023
Merged

phase 2 - added trade config #995

merged 15 commits into from
Nov 29, 2023

Conversation

sampocs
Copy link
Collaborator

@sampocs sampocs commented Nov 28, 2023

Brief Changelog

  • Added gov gate to update and delete txs
  • Added TradeConfig data structure to provide better organization to TradeRoute
  • Key'd TradeRoute by reward denom in it's native format instead of ibc format

@sampocs sampocs changed the title Sam/cp phase 2 trade config phase 2 - added trade config Nov 28, 2023
@sampocs sampocs changed the base branch from sam/cp-phase-2-proto-renaming to autoswap-revenue-tokens November 28, 2023 21:24
ethan-stride
ethan-stride reviewed Nov 28, 2023
View reviewed changes
Copy link
Contributor

@ethan-stride ethan-stride left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
The names are finally becoming consistent, it feels a lot more clean

proto/stride/stakeibc/tx.proto Show resolved Hide resolved
x/stakeibc/keeper/icqcallbacks_pool_price.go Outdated Show resolved Hide resolved
x/stakeibc/keeper/msg_server_delete_trade_route.go Show resolved Hide resolved
x/stakeibc/keeper/msg_server_create_trade_route.go Show resolved Hide resolved
@ethan-stride
Copy link
Contributor

LGTM

@sampocs sampocs merged commit 3e0917a into autoswap-revenue-tokens Nov 29, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ethan-stride ethan-stride ethan-stride left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sampocs @ethan-stride