Inflation Fix #951
Merged
Inflation Fix #951
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
asalzmann
reviewed
Oct 14, 2023
app/upgrades/v16/upgrades.go
Outdated
| ratelimitKeeper ratelimitkeeper.Keeper, | ||
| ) upgradetypes.UpgradeHandler { | ||
| return func(ctx sdk.Context, _ upgradetypes.Plan, vm module.VersionMap) (module.VersionMap, error) { | ||
| ctx.Logger().Info("Starting upgrade v15...") |
asalzmann
reviewed
Oct 14, 2023
| sdk "github.com/cosmos/cosmos-sdk/types" | ||
| ) | ||
|
|
||
| func (k msgServer) ResumeHostZone(goCtx context.Context, msg *types.MsgResumeHostZone) (*types.MsgResumeHostZoneResponse, error) { |
There was a problem hiding this comment.
We also need to remove the blacklisted denom right?
asalzmann
reviewed
Oct 14, 2023
| @@ -26,6 +26,7 @@ func RegisterCodec(cdc *codec.LegacyAmino) { | |||
| cdc.RegisterConcrete(&MsgUndelegateHost{}, "stakeibc/UndelegateHost", nil) | |||
| cdc.RegisterConcrete(&MsgCalibrateDelegation{}, "stakeibc/CalibrateDelegation", nil) | |||
| cdc.RegisterConcrete(&MsgUpdateInnerRedemptionRateBounds{}, "stakeibc/UpdateInnerRedemptionRateBounds", nil) | |||
| cdc.RegisterConcrete(&MsgResumeHostZone{}, "stakeibc/ResumeHostZone", nil) | |||
There was a problem hiding this comment.
Should we test this with ledger?
There was a problem hiding this comment.
It's a good point, let's test it in Dockernet
asalzmann
reviewed
Oct 14, 2023
| @@ -67,6 +67,9 @@ func NewMessageHandler(k keeper.Keeper) sdk.Handler { | |||
| case *types.MsgUpdateInnerRedemptionRateBounds: | |||
| res, err := msgServer.UpdateInnerRedemptionRateBounds(sdk.WrapSDKContext(ctx), msg) | |||
| return sdk.WrapServiceResult(ctx, res, err) | |||
| case *types.MsgResumeHostZone: | |||
There was a problem hiding this comment.
Should we test this on dockernet as well?
riley-stride
approved these changes
Oct 14, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes functionality after invariant checks
Test plan
Dockernet test - main functionality
make start-docker build=s && make test-integration-docker$STRIDE_MAIN_CMD tx stakeibc set-redemption-rate-bounds GAIA 1 1.000001 --from $STRIDE_ADMIN_ACCT -y | TRIM_TX$STRIDE_MAIN_CMD tx stakeibc set-redemption-rate-bounds GAIA 1 1.300001 --from $STRIDE_ADMIN_ACCT -y | TRIM_TX(2)$STRIDE_MAIN_CMD tx stakeibc resume-host-zone GAIA --from $STRIDE_ADMIN_ACCT -y | TRIM_TXDockernet test - ledger
ValidateBasic$STRIDE_MAIN_CMD tx stakeibc resume-host-zone GAIA --from ledger-test -y | TRIM_TX(error indicates the signing happened correctly, which is what we care about when testing ledger)