Added ICAOracle route implementations for legacy Msg type #923
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes: #XXX
Context and purpose of the change
Ledger transactions require each message to implement the legacy sdk.Msg type. The oracle messages did not implement the
Route
function of the interface, which caused ledger transactions to fail with the following error:panic: expected *legacytx.LegacyMsg when using amino JSON
Brief Changelog
Route
function for the following oracle transactions:Testing
@riley-stride recreated the error in dockernet and confirmed adding the
Route
implementation resolved the error.Note to Future Selves
Make sure to implement the legacy interface for ledger transactions.
Author's Checklist
I have...
If skipped any of the tests above, explain.
Reviewers Checklist
All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.
I have...
Documentation and Release Note
Unreleased
section inCHANGELOG.md
?How is the feature or change documented?
XXX
x/<module>/spec/
)