Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added ICAOracle route implementations for legacy Msg type #923

Merged
merged 2 commits into from
Sep 15, 2023

Conversation

sampocs
Copy link
Collaborator

@sampocs sampocs commented Sep 6, 2023

Closes: #XXX

Context and purpose of the change

Ledger transactions require each message to implement the legacy sdk.Msg type. The oracle messages did not implement the Route function of the interface, which caused ledger transactions to fail with the following error:

panic: expected *legacytx.LegacyMsg when using amino JSON

Brief Changelog

  • Implemented Route function for the following oracle transactions:
    • AddOracle
    • RemoveOracle
    • ToggleOracle
    • InstantiateOracle
    • RestoreOracleICA

Testing

@riley-stride recreated the error in dockernet and confirmed adding the Route implementation resolved the error.

Note to Future Selves

Make sure to implement the legacy interface for ledger transactions.

Author's Checklist

I have...

  • Run and PASSED locally all GAIA integration tests
  • If the change is contentful, I either:
    • Added a new unit test OR
    • Added test cases to existing unit tests
  • OR this change is a trivial rework / code cleanup without any test coverage

If skipped any of the tests above, explain.

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

  • reviewed state machine logic
  • reviewed API design and naming
  • manually tested (if applicable)
  • confirmed the author wrote unit tests for new logic
  • reviewed documentation exists and is accurate

Documentation and Release Note

  • Does this pull request introduce a new feature or user-facing behavior changes?
  • Is a relevant changelog entry added to the Unreleased section in CHANGELOG.md?
  • This pull request updates existing proto field values (and require a backend and frontend migration)?
  • Does this pull request change existing proto field names (and require a frontend migration)?
    How is the feature or change documented?
    • not applicable
    • jira ticket XXX
    • specification (x/<module>/spec/)
    • README.md
    • not documented

@sampocs sampocs changed the title added ICAOracle route implementations for legacy Msg type Added ICAOracle route implementations for legacy Msg type Sep 6, 2023
Copy link
Contributor

@riley-stride riley-stride left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Tested add and instantiate on dockernet with ledger and ledger multisig but not remove or restore or toggle.

@sampocs sampocs merged commit b304954 into main Sep 15, 2023
@sampocs
Copy link
Collaborator Author

sampocs commented Sep 15, 2023

remove/restore/toggle are all gov functions so no need to test!

@sampocs sampocs mentioned this pull request Sep 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants