Removed consumer param store updates #892
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shellvish
approved these changes
Aug 10, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes: #XXX
Context and purpose of the change
The CCV paramstore runs a bech32 address verification on the provider fee pool address; however, it tries to verify the address using the consumer chain's address prefix, causing the validation to fail (i.e. it tries to verify a
cosmosaddress by checking if it has astrideprefix. This should be resolved in ICS before the consumer keeper can safely set params. As a result, this PR removes all occurrences ofConsumerKeeper.SetParams`.Brief Changelog
RegisterStTokenDenomsToWhitelistin upgrade handler and host zone registration (RegisterStTokenDenomsToWhitelistcallsConsumerKeeper.SetParams)Upgrades Tests
integration_tests.bats ✓ [INTEGRATION-BASIC-GAIA] host zones successfully registered ✓ [INTEGRATION-BASIC-GAIA] ibc transfer updates all balances ✓ [INTEGRATION-BASIC-GAIA] liquid stake mint and transfer ✓ [INTEGRATION-BASIC-GAIA] packet forwarding automatically liquid stakes ✓ [INTEGRATION-BASIC-GAIA] tokens on GAIA were staked ✓ [INTEGRATION-BASIC-GAIA] redemption works ✓ [INTEGRATION-BASIC-GAIA] claimed tokens are properly distributed ✓ [INTEGRATION-BASIC-GAIA] rewards are being reinvested, exchange rate updating ✓ [INTEGRATION-BASIC-GAIA] rewards are being distributed to stakers // upgrade passed integration_tests.bats ✓ [INTEGRATION-BASIC-EVMOS] host zones successfully registered ✓ [INTEGRATION-BASIC-EVMOS] ibc transfer updates all balances ✓ [INTEGRATION-BASIC-EVMOS] liquid stake mint and transfer - [INTEGRATION-BASIC-EVMOS] packet forwarding automatically liquid stakes (skipped: Packet forward liquid stake test is only run on GAIA and HOST) ✓ [INTEGRATION-BASIC-EVMOS] tokens on EVMOS were staked ✓ [INTEGRATION-BASIC-EVMOS] redemption works ✓ [INTEGRATION-BASIC-EVMOS] claimed tokens are properly distributed ✓ [INTEGRATION-BASIC-EVMOS] rewards are being reinvested, exchange rate updating ✓ [INTEGRATION-BASIC-EVMOS] rewards are being distributed to stakers integration_tests.bats ✓ [INTEGRATION-BASIC-HOST] host zones successfully registered ✓ [INTEGRATION-BASIC-HOST] ibc transfer updates all balances ✓ [INTEGRATION-BASIC-HOST] liquid stake mint and transfer ✓ [INTEGRATION-BASIC-HOST] packet forwarding automatically liquid stakes ✓ [INTEGRATION-BASIC-HOST] tokens on HOST were staked ✓ [INTEGRATION-BASIC-HOST] redemption works ✓ [INTEGRATION-BASIC-HOST] claimed tokens are properly distributed ✓ [INTEGRATION-BASIC-HOST] rewards are being reinvested, exchange rate updating ✓ [INTEGRATION-BASIC-HOST] rewards are being distributed to stakers